feat(android): use pending intent in background #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks really good @omercnet I'll kick the tires on it a bit later in the week. Thanks for the patch! |
peitschie
requested changes
Oct 30, 2024
| <uses-permission | ||
| android:name="android.permission.BLUETOOTH" | ||
| android:maxSdkVersion="30" /> | ||
| <uses-permission | ||
| android:name="android.permission.BLUETOOTH_ADMIN" | ||
| android:maxSdkVersion="30" /> | ||
|
|
There was a problem hiding this comment.
These permission changes do not seem necessary. Are you able to revert everything other than the new receiver block?
| if (!isScanning) { | ||
| setTimeoutForStopScanning() | ||
| Logger.debug(TAG, "Start scanning.") | ||
| Logger.debug(TAG, "Start scanning" + (if (usePendingIntent) " with pendingIntent!" else ".")) |
There was a problem hiding this comment.
Very minor, but it would be better to put this debug log into the if statement so the log is accurate for Android 7 and lower
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #699
adding an optional parameter that ensures Android will use a pending intent for scan results