Fix ios review

[cp-sneha-s]

Purpose

Summary of Changes

Test steps

Conformity

• Followed git guidelines for creating commit messages and Pull Request guidelines.
• Self-approved the PR - reviewed the PR as a reviewer and gave it self-approval if everything is ok. If not, made the required changes.
• Ensured that the PR satisfies all specified requirements in the ticket, including bug fixes and new features.
• Provided test steps, including steps to reproduce the issue or test the new functionality, ensuring other team members can verify the changes.
• Added/Updated proper code comments to make it easy-to-understand for other developers.
• Reused code (if the same code was written twice, made it common and reused it at both places).
• Removed unused or commented code if not required.
• Ensured proper Dart naming conventions were used for variables, classes, and methods.
• Localized user-facing strings.
• Included screenshots/videos of behavior changes: Provided visual evidence of any changes to UI or behavior for easier review and understanding in the PR description.
• Implemented proper error handling: Ensured that the code anticipated and handled potential errors and edge cases gracefully.
• Avoided introducing technical debt: If the PR introduces technical debt, created and linked appropriate tickets for future resolution.
• Included relevant unit tests: Wrote unit tests that focused on testing behavior and functionality, rather than merely covering lines of code.
• Ensured code was performant and scalable: Verified that the changes did not introduce performance issues or bottlenecks and could scale as needed.
• Ensured comments were up-to-date and relevant to the code to describe complex logic and to add understanding for other developers.
• Marked the PR as ready before submitting it for review.

Visual Evidence (Video, Images or Gif)

Summary by CodeRabbit

• New Features
  • Introduced privacy settings for specific API categories in the app.
  • Added a new privacy information file to enhance user data protection.
  • Updated the app to filter and display celebrations for active employees only.
• Updates
  • Updated the app version to improve functionality and user experience.
• Bug Fixes
  • Fixed an issue related to app encryption declaration to comply with store policies.
• Refactor
  • Adjusted project configurations for better development practices.

[coderabbitai]

Walkthrough

The latest update introduces privacy enhancements, version adjustments, and a focus on active employee data. A new privacy info file and a key in the Info.plist ensure compliance with encryption standards. Versioning has been standardized across the project, and the app's development environment is now specified. Additionally, the employee celebrations feature has been refined to include only active employees, ensuring relevancy and accuracy in celebrations.

Changes

Files	Change Summary
.../project.pbxproj, .../Info.plist	Updated versions, added PrivacyInfo.xcprivacy, and encryption key.
.../PrivacyInfo.xcprivacy	Introduced privacy settings for API access reasons.
.../Runner.entitlements	Added aps-environment key with development value.
lib/.../events/bloc/celebrations_bloc.dart	Filtered to include only active employees in celebrations.

🐰✨
In the realm of code, where changes abound,
A rabbit hopped in, leaving tracks on the ground.
"To privacy and joy," it whispered with glee,
"For active ones only, as lively as can be!"
🌟📱 Upgrades and tweaks, in harmony they blend,
In this digital burrow, where bytes do ascend.
🥕🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between cdb0871 and 4b435d1.

Files selected for processing (6)

• ios/Runner.xcodeproj/project.pbxproj (8 hunks)
• ios/Runner/Info.plist (1 hunks)
• ios/Runner/PrivacyInfo.xcprivacy (1 hunks)
• ios/Runner/Runner.entitlements (1 hunks)
• lib/ui/shared/events/bloc/celebrations_bloc.dart (1 hunks)
• pubspec.yaml (1 hunks)

Files skipped from review due to trivial changes (1)

• pubspec.yaml

Additional Context Used

Additional comments not posted (6)

ios/Runner/Runner.entitlements (1)

5-6: The addition of the aps-environment key with the value development is appropriate for enabling push notifications in a development environment. Ensure that for production builds, this value is changed to production to correctly configure push notifications.

ios/Runner/PrivacyInfo.xcprivacy (1)

1-17: The addition of PrivacyInfo.xcprivacy with privacy information settings is crucial for compliance with privacy requirements. Ensure that the reason codes provided, such as 3B52.1, are well-documented and justified in accordance with the project's privacy policy.

ios/Runner/Info.plist (1)

77-78: The addition of the ITSAppUsesNonExemptEncryption key with a value of false is correctly implemented, indicating the app does not use exempt encryption. This is important for compliance with export laws and App Store submission requirements.

lib/ui/shared/events/bloc/celebrations_bloc.dart (1)

34-36: The modification to filter allEmployees by status before mapping them to employees is a logical improvement, ensuring that only active employees are considered. This enhances the data processing efficiency and relevance.

ios/Runner.xcodeproj/project.pbxproj (2)

40-40: The addition of PrivacyInfo.xcprivacy to the project file is correctly implemented, ensuring the new privacy settings file is included in the project structure.

---

414-420: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [417-427]

The updates to CURRENT_PROJECT_VERSION to 1.0.2 and MARKETING_VERSION to 1 across different configurations (Debug, Release, Profile) are correctly applied, reflecting the intended versioning changes for the project.

Also applies to: 554-564, 586-597

[coderabbitai]

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 4b435d1 and bfc943e.

Files selected for processing (2)

• ios/PrivacyInfo.xcprivacy (1 hunks)
• lib/ui/shared/events/bloc/celebrations_bloc.dart (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• lib/ui/shared/events/bloc/celebrations_bloc.dart

Additional Context Used

Additional comments not posted (1)

ios/PrivacyInfo.xcprivacy (1)

12-12: The value 3B52.1 under NSPrivacyAccessedAPITypeReasons has been updated. Ensure this change is accurately reflected in any user-facing documentation or privacy policies related to the app's use of this API category. It's important to keep such documentation up-to-date to comply with privacy regulations and inform users appropriately.