Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mobile page speed #581

Merged
merged 6 commits into from
Jun 28, 2024
Merged

Improve mobile page speed #581

merged 6 commits into from
Jun 28, 2024

Conversation

cp-dharti-r
Copy link
Collaborator

@cp-dharti-r cp-dharti-r commented Jun 25, 2024 •
edited
Loading

Review checklist

Note: Make sure all points should be checked before submiting PR for review, otherwise PR will be cosidered invalid.

  • Follow guidelines for creating branch name, adding commit messages or PR title
  • Add MR description if applicable
  • Follow guidelines for naming conventions everywhere (i.e files/folders, data structures)
  • Reuse code (if the same code is written twice, make it common and reuse it at both places)
  • Remove unused or commented code if not required
  • Make MR self-approved - review MR as a reviewer and give it self-approval if everything is ok, if not make the required changes
  • In progress MR should be marked as draft
  • Make MR mark as ready before submitting it for review
  • Add images, videos, or gifs of UI
  • Add page speed score screenshot of UI (It should be > 85 for mobile and > 90 for desktops)

Design should be tested on:

  • Inspector (all iPhones and android devices like samsung, motorola)
  • Desktop (chrome, firefox, safari)
  • Laptop / Macbook (chrome, firefox, safari)
  • iPhone(safari)
  • Available android devices (chrome, firefox)
  • iPad(safari)
  • Tablet (chrome, firefox)

PR Description

@cp-dharti-r cp-dharti-r changed the title Draft: Use nuxt-img in home page to see performance Draft: Improve mobile page speed Jun 28, 2024
@cp-dharti-r cp-dharti-r force-pushed the use-nuxt-image-to-show-images branch from 1bb9f50 to 1761699 Compare June 28, 2024 06:57
@cp-dharti-r cp-dharti-r changed the title Draft: Improve mobile page speed Improve mobile page speed Jun 28, 2024
cp-sumi-k
cp-sumi-k requested changes Jun 28, 2024
View reviewed changes
nuxt-frontend/pages/portfolio/[id].vue Outdated Show resolved Hide resolved
nuxt-frontend/package.json Outdated Show resolved Hide resolved
@cp-sumi-k
Copy link
Member

There were many images added, Please add reason for adding images in description

cp-sumi-k
cp-sumi-k previously approved these changes Jun 28, 2024
View reviewed changes
@cp-dharti-r cp-dharti-r merged commit 76ad4e5 into master Jun 28, 2024
2 checks passed
@cp-dharti-r cp-dharti-r deleted the use-nuxt-image-to-show-images branch June 28, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cp-sumi-k cp-sumi-k cp-sumi-k approved these changes

@nidhi-canopas nidhi-canopas nidhi-canopas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cp-dharti-r @cp-sumi-k @nidhi-canopas