Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Getting some null values from database for blog #576

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Fix - Getting some null values from database for blog #576

merged 1 commit into from
Apr 26, 2024

Conversation

cp-dharti-r
Copy link
Collaborator

@cp-dharti-r cp-dharti-r commented Apr 26, 2024 •
edited
Loading

Review checklist

Note: Make sure all points should be checked before submiting PR for review, otherwise PR will be cosidered invalid.

  • Follow guidelines for creating branch name, adding commit messages or PR title
  • Add MR description if applicable
  • Follow guidelines for naming conventions everywhere (i.e files/folders, data structures)
  • Reuse code (if the same code is written twice, make it common and reuse it at both places)
  • Remove unused or commented code if not required
  • Make MR self-approved - review MR as a reviewer and give it self-approval if everything is ok, if not make the required changes
  • In progress MR should be marked as draft
  • Make MR mark as ready before submitting it for review
  • Add images, videos, or gifs of UI
  • Add page speed score screenshot of UI (It should be > 85 for mobile and > 90 for desktops)

Design should be tested on:

  • Inspector (all iPhones and android devices like samsung, motorola)
  • Desktop (chrome, firefox, safari)
  • Laptop / Macbook (chrome, firefox, safari)
  • iPhone(safari)
  • Available android devices (chrome, firefox)
  • iPad(safari)
  • Tablet (chrome, firefox)

MR Description

  • Update Post struct
    • Update published_on, toc, content datatype to null.String as it's having null values

@cp-dharti-r cp-dharti-r force-pushed the fix-publish-on-null-string branch from 309cf58 to 6fa4238 Compare April 26, 2024 05:10
@cp-dharti-r cp-dharti-r force-pushed the fix-publish-on-null-string branch from 0548cc4 to 87e112e Compare April 26, 2024 05:32
@cp-dharti-r cp-dharti-r changed the title Fix - published_on null value Fix - Getting some null values from database for blog Apr 26, 2024
@cp-dharti-r cp-dharti-r merged commit 19ffdd3 into master Apr 26, 2024
2 checks passed
@cp-dharti-r cp-dharti-r deleted the fix-publish-on-null-string branch April 26, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidhi-canopas nidhi-canopas nidhi-canopas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cp-dharti-r @nidhi-canopas