Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Implement GET APIs for posts #574

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Feat: Implement GET APIs for posts #574

merged 1 commit into from
Apr 24, 2024

Conversation

cp-dharti-r
Copy link
Collaborator

@cp-dharti-r cp-dharti-r commented Apr 19, 2024 •
edited
Loading

Review checklist

Note: Make sure all points should be checked before submiting PR for review, otherwise PR will be cosidered invalid.

  • Follow guidelines for creating branch name, adding commit messages or PR title
  • Add MR description if applicable
  • Follow guidelines for naming conventions everywhere (i.e files/folders, data structures)
  • Reuse code (if the same code is written twice, make it common and reuse it at both places)
  • Remove unused or commented code if not required
  • Make MR self-approved - review MR as a reviewer and give it self-approval if everything is ok, if not make the required changes
  • In progress MR should be marked as draft
  • Make MR mark as ready before submitting it for review
  • Add images, videos, or gifs of UI
  • Add page speed score screenshot of UI (It should be > 85 for mobile and > 90 for desktops)

Design should be tested on:

  • Inspector (all iPhones and android devices like samsung, motorola)
  • Desktop (chrome, firefox, safari)
  • Laptop / Macbook (chrome, firefox, safari)
  • iPhone(safari)
  • Available android devices (chrome, firefox)
  • iPad(safari)
  • Tablet (chrome, firefox)

Description

  • Implement GET APIs for blogs and resources
  • Update required changes to call the API

@cp-dharti-r cp-dharti-r force-pushed the implement-get-apis-for-post branch from 559f7dc to 8c39f74 Compare April 22, 2024 13:32
nidhi-canopas
nidhi-canopas reviewed Apr 23, 2024
View reviewed changes
.github/workflows/deploy-backend-dev.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-backend-dev.yml Outdated Show resolved Hide resolved
db/blog_sql.go Outdated Show resolved Hide resolved
infrastructure/backend.yml Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
post/index.go Outdated Show resolved Hide resolved
post/author.go Show resolved Hide resolved
post/index.go Outdated Show resolved Hide resolved
post/index.go Outdated Show resolved Hide resolved
utils/helper.go Outdated Show resolved Hide resolved
@cp-dharti-r cp-dharti-r force-pushed the implement-get-apis-for-post branch from bd8b13b to 9c4d8a3 Compare April 23, 2024 11:39
nidhi-canopas
nidhi-canopas previously approved these changes Apr 23, 2024
View reviewed changes
@cp-dharti-r cp-dharti-r force-pushed the implement-get-apis-for-post branch from d021fb8 to 5b4bf02 Compare April 24, 2024 04:17
@cp-dharti-r cp-dharti-r merged commit 4202f58 into master Apr 24, 2024
2 checks passed
@cp-dharti-r cp-dharti-r deleted the implement-get-apis-for-post branch April 24, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidhi-canopas nidhi-canopas nidhi-canopas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cp-dharti-r @nidhi-canopas