Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance : Redesign Development section for desktop of android page #567

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Enhance : Redesign Development section for desktop of android page #567

merged 1 commit into from
Mar 6, 2024

Conversation

cp-jagruti-a
Copy link
Contributor

@cp-jagruti-a cp-jagruti-a commented Mar 6, 2024 •
edited
Loading

Review checklist

Note: Make sure all points should be checked before submiting PR for review, otherwise PR will be cosidered invalid.

  • Follow guidelines for creating branch name, adding commit messages or PR title
  • Add MR description if applicable
  • Follow guidelines for naming conventions everywhere (i.e files/folders, data structures)
  • Reuse code (if the same code is written twice, make it common and reuse it at both places)
  • Remove unused or commented code if not required
  • Make MR self-approved - review MR as a reviewer and give it self-approval if everything is ok, if not make the required changes
  • In progress MR should be marked as draft
  • Make MR mark as ready before submitting it for review
  • Add images, videos, or gifs of UI
  • Add page speed score screenshot of UI (It should be > 85 for mobile and > 90 for desktops)

UI Video :
Screencast from 06-03-24 12:44:13 PM IST.webm

@cp-jagruti-a cp-jagruti-a force-pushed the redesign-androidapp-page-development-section branch from ec54577 to cfa9b2e Compare March 6, 2024 07:12
@cp-jagruti-a cp-jagruti-a changed the title Enhance : Redesign Development section of android page Enhance : Redesign Development section for desktop of android page Mar 6, 2024
@cp-jagruti-a cp-jagruti-a force-pushed the redesign-androidapp-page-development-section branch from 14a087e to 3ef867a Compare March 6, 2024 10:13
@cp-jagruti-a cp-jagruti-a merged commit 18ed5c8 into master Mar 6, 2024
2 checks passed
@cp-jagruti-a cp-jagruti-a deleted the redesign-androidapp-page-development-section branch March 6, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cp-dharti-r cp-dharti-r cp-dharti-r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cp-jagruti-a @cp-dharti-r