Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance : Unification in home page #515

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

cp-jagruti-a
Copy link
Contributor

@cp-jagruti-a cp-jagruti-a commented Dec 1, 2023

Review checklist

Note: Make sure all points should be checked before submiting PR for review, otherwise PR will be cosidered invalid.

  • Follow guidelines for creating branch name, adding commit messages or PR title
  • Add MR description if applicable
  • Follow guidelines for naming conventions everywhere (i.e files/folders, data structures)
  • Reuse code (if the same code is written twice, make it common and reuse it at both places)
  • Remove unused or commented code if not required
  • Make MR self-approved - review MR as a reviewer and give it self-approval if everything is ok, if not make the required changes
  • In progress MR should be marked as draft
  • Make MR mark as ready before submitting it for review
  • Add images, videos, or gifs of UI
  • Add page speed score screenshot of UI (It should be > 85 for mobile and > 90 for desktops)

Design should be tested on:

  • Inspector (all iPhones and android devices like samsung, motorola)
  • Desktop (chrome, firefox, safari)
  • Laptop / Macbook (chrome, firefox, safari)
  • iPhone(safari)
  • Available android devices (chrome, firefox)
  • iPad(safari)
  • Tablet (chrome, firefox)

Description :

  • Done Unification in whole home page
  • changed some designs according to new design
  • also changed some classes names in other component files

UI Videos :
Screencast from 19-12-23 04:47:54 PM IST.webm
Screencast from 19-12-23 04:48:13 PM IST.webm

@cp-jagruti-a cp-jagruti-a marked this pull request as draft December 13, 2023 05:00
@cp-jagruti-a cp-jagruti-a force-pushed the unification-in-home-page branch 3 times, most recently from 955da56 to fec176b Compare December 18, 2023 05:40
@cp-jagruti-a cp-jagruti-a marked this pull request as ready for review December 19, 2023 09:01
@cp-jagruti-a cp-jagruti-a marked this pull request as draft December 19, 2023 09:01
@cp-jagruti-a cp-jagruti-a force-pushed the unification-in-home-page branch from e53edb0 to a7fc06a Compare December 19, 2023 11:16
@cp-jagruti-a cp-jagruti-a marked this pull request as ready for review December 19, 2023 11:22
@cp-jagruti-a cp-jagruti-a force-pushed the unification-in-home-page branch from 4dc4a93 to 06a5b2a Compare December 19, 2023 11:26
@cp-jagruti-a cp-jagruti-a force-pushed the unification-in-home-page branch 2 times, most recently from b66b15f to c103007 Compare December 20, 2023 05:47
cp-ashish-k
cp-ashish-k previously approved these changes Dec 20, 2023
@cp-jagruti-a cp-jagruti-a force-pushed the unification-in-home-page branch 2 times, most recently from d671de5 to 670271b Compare December 20, 2023 07:38
nuxt-frontend/assets/css/global.css Outdated Show resolved Hide resolved
nuxt-frontend/assets/css/global.css Outdated Show resolved Hide resolved
nuxt-frontend/assets/css/global.css Outdated Show resolved Hide resolved
nuxt-frontend/assets/css/global.css Outdated Show resolved Hide resolved
nuxt-frontend/assets/css/global.css Outdated Show resolved Hide resolved
@cp-jagruti-a cp-jagruti-a force-pushed the unification-in-home-page branch from aaade91 to 1c55228 Compare December 21, 2023 04:32
@cp-jagruti-a cp-jagruti-a force-pushed the unification-in-home-page branch from 3f2aed0 to 68dad08 Compare December 21, 2023 07:08
@cp-jagruti-a cp-jagruti-a force-pushed the unification-in-home-page branch from 72f731b to d80edd3 Compare December 21, 2023 07:35
@cp-jagruti-a cp-jagruti-a merged commit f25a345 into master Dec 21, 2023
2 checks passed
@cp-jagruti-a cp-jagruti-a deleted the unification-in-home-page branch December 21, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants