Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance : Design android app page according to new resolutions design #497

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Enhance : Design android app page according to new resolutions design #497

merged 1 commit into from
Oct 23, 2023

Conversation

cp-jagruti-a
Copy link
Contributor

@cp-jagruti-a cp-jagruti-a commented Oct 20, 2023 •
edited
Loading

Review checklist

Note: Make sure all points should be checked before submiting PR for review, otherwise PR will be cosidered invalid.

  • Follow guidelines for creating branch name, adding commit messages or PR title
  • Add MR description if applicable
  • Follow guidelines for naming conventions everywhere (i.e files/folders, data structures)
  • Reuse code (if the same code is written twice, make it common and reuse it at both places)
  • Remove unused or commented code if not required
  • Make MR self-approved - review MR as a reviewer and give it self-approval if everything is ok, if not make the required changes
  • In progress MR should be marked as draft
  • Make MR mark as ready before submitting it for review
  • Add images, videos, or gifs of UI
  • Add page speed score screenshot of UI (It should be > 85 for mobile and > 90 for desktops)

Design should be tested on:

  • Inspector (all iPhones and android devices like samsung, motorola)
  • Desktop (chrome, firefox, safari)
  • Laptop / Macbook (chrome, firefox, safari)
  • iPhone(safari)
  • Available android devices (chrome, firefox)
  • iPad(safari)
  • Tablet (chrome, firefox)

Description:

  • Created new outer container for larger devices
  • Fixed 4k design
  • used desktop design from lg devices

Video:

Screencast.from.23-10-23.12.56.59.PM.IST.webm

@cp-jagruti-a cp-jagruti-a force-pushed the design-android-page-according-to-new-resolutions branch from 39df650 to 1badecf Compare October 23, 2023 07:22
@cp-jagruti-a cp-jagruti-a force-pushed the design-android-page-according-to-new-resolutions branch from b8bbe57 to 5583c17 Compare October 23, 2023 10:00
@cp-jagruti-a cp-jagruti-a merged commit 3ada9a8 into master Oct 23, 2023
2 checks passed
@cp-jagruti-a cp-jagruti-a deleted the design-android-page-according-to-new-resolutions branch October 23, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cp-priyanka-g cp-priyanka-g cp-priyanka-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cp-jagruti-a @cp-priyanka-g