Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance #480

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Improve performance #480

merged 1 commit into from
Sep 12, 2023

Conversation

cp-jagruti-a
Copy link
Contributor

@cp-jagruti-a cp-jagruti-a commented Sep 1, 2023

Review checklist

Note: Make sure all points should be checked before submiting PR for review, otherwise PR will be cosidered invalid.

  • Follow guidelines for creating branch name, adding commit messages or PR title
  • Add MR description if applicable
  • Follow guidelines for naming conventions everywhere (i.e files/folders, data structures)
  • Reuse code (if the same code is written twice, make it common and reuse it at both places)
  • Remove unused or commented code if not required
  • Make MR self-approved - review MR as a reviewer and give it self-approval if everything is ok, if not make the required changes
  • In progress MR should be marked as draft
  • Make MR mark as ready before submitting it for review
  • Add images, videos, or gifs of UI
  • Add page speed score screenshot of UI (It should be > 85 for mobile and > 90 for desktops)

Design should be tested on:

  • Inspector (all iPhones and android devices like samsung, motorola)
  • Desktop (chrome, firefox, safari)
  • Laptop / Macbook (chrome, firefox, safari)
  • iPhone(safari)
  • Available android devices (chrome, firefox)
  • iPad(safari)
  • Tablet (chrome, firefox)

Page speed Score :
Home page :
Desktop:
Screenshot from 2023-09-12 15-06-27
Mobile:
Screenshot from 2023-09-12 15-06-17

Portfolio :
Desktop:
Screenshot from 2023-09-12 14-59-17
Mobile:
Screenshot from 2023-09-12 14-59-07

About Us
Desktop:
Screenshot from 2023-09-12 15-02-23
Mobile:
Screenshot from 2023-09-12 15-02-14

@cp-jagruti-a cp-jagruti-a changed the title Improve portfolio page performance Improve performance Sep 12, 2023
@cp-jagruti-a cp-jagruti-a merged commit c916d88 into master Sep 12, 2023
2 checks passed
@cp-jagruti-a cp-jagruti-a deleted the improve-performance branch September 12, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants