Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Always show Pro token input #980

Merged
merged 5 commits into from
Nov 27, 2024
Merged

feat: Always show Pro token input #980

merged 5 commits into from
Nov 27, 2024

Conversation

ashuntu
Copy link
Collaborator

@ashuntu ashuntu commented Nov 25, 2024

Shows the token input field always instead of being in a collapsible section. Also, adds messaging when a valid token or invalid token is added, with an icon.

A small detail I missed when adjusting the copy for errors previously: invalid tokens now show the string "Invalid token" instead of "Token invalid".

Screenshot of the default look

image

Screenshot when an invalid token is entered

image

Screenshot when a valid token is entered

image

Our designs in Figma include functionality that we do not have, so I took some creative liberties in adapting it to the current layout. Let me know if it needs any adjustments.


UDENG-5284

Shows the token input field always instead of being in a collapsible section. Also, adds messaging when a valid token or invalid token is added, with an icon.
@ashuntu ashuntu self-assigned this Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.10%. Comparing base (24b3b5d) to head (a9c1fd8).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #980      +/-   ##
==========================================
- Coverage   89.12%   89.10%   -0.03%     
==========================================
  Files         110      110              
  Lines        7494     7515      +21     
==========================================
+ Hits         6679     6696      +17     
- Misses        636      638       +2     
- Partials      179      181       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashuntu ashuntu marked this pull request as ready for review November 26, 2024 01:39
@ashuntu ashuntu requested a review from a team as a code owner November 26, 2024 01:39
Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your proposal finds a good balance between the stuff we know we need to change and the amount we don't know yet.
One of the key benefits of the recent releases of Yaru is the consistency brought by YaruColors. Thus my questions about whether we're approaching them properly or not.

@ashuntu
Copy link
Collaborator Author

ashuntu commented Nov 26, 2024

I converted the colors to Yaru colors. The status page also uses a modified version of success that is extremely close to the custom value we were using (is there a built-in version of this I don't know about?).

@CarlosNihelton
Copy link
Contributor

I converted the colors to Yaru colors. The status page also uses a modified version of success that is extremely close to the custom value we were using (is there a built-in version of this I don't know about?).

I suspect if you use the YaruInfo widget you'll get the correct colors for free ;)

@ashuntu
Copy link
Collaborator Author

ashuntu commented Nov 26, 2024

I suspect if you use the YaruInfo widget you'll get the correct colors for free ;)

That looks promising, I think I will do that in another PR since its unrelated to the token page.

Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@ashuntu ashuntu merged commit c7baeea into main Nov 27, 2024
36 checks passed
@ashuntu ashuntu deleted the always-show-input branch November 27, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants