-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Always show Pro token input #980
Conversation
Shows the token input field always instead of being in a collapsible section. Also, adds messaging when a valid token or invalid token is added, with an icon.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #980 +/- ##
==========================================
- Coverage 89.12% 89.10% -0.03%
==========================================
Files 110 110
Lines 7494 7515 +21
==========================================
+ Hits 6679 6696 +17
- Misses 636 638 +2
- Partials 179 181 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your proposal finds a good balance between the stuff we know we need to change and the amount we don't know yet.
One of the key benefits of the recent releases of Yaru is the consistency brought by YaruColors. Thus my questions about whether we're approaching them properly or not.
gui/packages/ubuntupro/lib/pages/subscribe_now/subscribe_now_widgets.dart
Outdated
Show resolved
Hide resolved
gui/packages/ubuntupro/lib/pages/subscribe_now/subscribe_now_widgets.dart
Outdated
Show resolved
Hide resolved
gui/packages/ubuntupro/lib/pages/subscribe_now/subscribe_now_widgets.dart
Outdated
Show resolved
Hide resolved
gui/packages/ubuntupro/lib/pages/subscribe_now/subscribe_now_widgets.dart
Outdated
Show resolved
Hide resolved
I converted the colors to Yaru colors. The status page also uses a modified version of |
gui/packages/ubuntupro/lib/pages/subscribe_now/subscribe_now_widgets.dart
Show resolved
Hide resolved
I suspect if you use the |
That looks promising, I think I will do that in another PR since its unrelated to the token page. |
gui/packages/ubuntupro/lib/pages/subscription_status/subscription_status_widgets.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Shows the token input field always instead of being in a collapsible section. Also, adds messaging when a valid token or invalid token is added, with an icon.
A small detail I missed when adjusting the copy for errors previously: invalid tokens now show the string "Invalid token" instead of "Token invalid".
Screenshot of the default look
Screenshot when an invalid token is entered
Screenshot when a valid token is entered
Our designs in Figma include functionality that we do not have, so I took some creative liberties in adapting it to the current layout. Let me know if it needs any adjustments.
UDENG-5284