fix(gui-ubuntupro): Verify certificate files #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This validates files based on file extension, then, if possible, if the file contains the correct certificate delimiters.
Sometimes (notably, when going from an error state to a non-error state), the previous error will be retained on the screen. This makes sure every change of the path is validated and updated.
Existing apply config tests were missing the ssl key portion, this commits add that.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #949 +/- ##
==========================================
+ Coverage 89.03% 89.08% +0.04%
==========================================
Files 110 110
Lines 7445 7506 +61
==========================================
+ Hits 6629 6687 +58
- Misses 638 639 +1
- Partials 178 180 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Note that the dummy binary_cert.der file is a file of random bytes, not necessarily a real certificate.
CarlosNihelton
requested changes
Nov 18, 2024
gui/packages/ubuntupro/lib/pages/landscape/landscape_model.dart
Outdated
Show resolved
Hide resolved
ashuntu
commented
Nov 18, 2024
gui/packages/ubuntupro/lib/pages/landscape/landscape_model.dart
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds verification for certificate files by first checking their file extension, and, if possible, their content. If a certificate path isn't a valid certificate, an error is shown in the UI and continuing is blocked.
Example invalid certificate file
Fixes #880
UDENG-5109