docs: How-to create WSL instances on multiple Windows machines via Landscape API #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosNihelton
force-pushed
the
htg-landscape-api
branch
from
23cad90 to
3f3c0e2
Compare
|
CI Link check is now failing mainly due this page about MS Store requirements which no longer exists. I didn't find a suitable replacement for that page so far. Even asked on one MS forum. |
edibotopic
reviewed
Oct 4, 2024
edibotopic
reviewed
Oct 4, 2024
edibotopic
reviewed
Oct 4, 2024
edibotopic
reviewed
Oct 4, 2024
edibotopic
reviewed
Oct 4, 2024
edibotopic
reviewed
Oct 4, 2024
edibotopic
reviewed
Oct 4, 2024
edibotopic
reviewed
Oct 4, 2024
edibotopic
reviewed
Oct 4, 2024
edibotopic
reviewed
Oct 4, 2024
edibotopic
reviewed
Oct 4, 2024
edibotopic
reviewed
Oct 4, 2024
edibotopic
requested changes
Oct 4, 2024
There was a problem hiding this comment.
This is great Carlos -- thank you.
It's also a really excellent use of the tabbed interface.
I have a few minor comments, mostly around wording but nothing major.
I could not find an alternative for that broken MS Store link either -- we may need to just remove it for now.
Rephrased that line a bit to ack the fact that it's still possible to install custom rootfses from Landscape if MS Store is not accessible.
Landscape docs already feature a quite complete guide on how to create WSL instances on Windows machines via Landscape API. Here we take a subset of that documentation and put it in shape for use with PowerShell (alongside Bash). This guide's focus is to deploy WSL instances from a custom rootfs with some cloud-config data for further customisation, using Landscape API to do it at scale, with both Bash and PowerShell alternatives. We keep a cross-reference to the existing Landscape docs, which are more complete.
- Consistent use of periods. - Link to the config landscape howto. - "using Bash" instead of "on a Linux machine"
CarlosNihelton
force-pushed
the
htg-landscape-api
branch
from
7170991 to
2dc6de8
Compare
Those links were timing out in CI linkcheck. The UP4W is only accessible from authorised users logged in, linkcheck will always fail, thus excluded.
|
LGTM: thanks for pulling this together! |
edibotopic
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes heavy use of tabbed code blocks to show alternative ways to do things with Bash and PowerShell.
Both alternatives were tested. The bash one comes from the Landscape documentation, I essentially extracted the piece I was more concerned about (custom rootfs with cloud-init data) and made a self-contained guide out of it (plus translating to PowerShell).
UDENG-4694