Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added firewall requirements #709

Merged
merged 2 commits into from
Apr 4, 2024
Merged

docs: added firewall requirements #709

merged 2 commits into from
Apr 4, 2024

Conversation

jibel
Copy link
Contributor

@jibel jibel commented Apr 3, 2024

Documented firewall requirements with a diagram and a table.
Added a link to the requirements from the how to set up page.

UDENG-2446

@jibel jibel requested a review from a team as a code owner April 3, 2024 20:49
Documented firewall requirements with a diagram and a table.
Added a link to the requirements from the how to set up page.
@jibel jibel force-pushed the docs_add_firewall_rules branch from ff08d41 to cb7d312 Compare April 4, 2024 07:06
Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contracts link should be https, shouldn't it? My other comments are nitpicks. Feel free to disregargd them.

docs/custom_conf.py Show resolved Hide resolved
docs/reference/firewall_requirements.md Outdated Show resolved Hide resolved
docs/reference/firewall_requirements.md Outdated Show resolved Hide resolved
Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The broken link is unrelated, and after a second attempt the link check will certainly succeed.

@jibel jibel merged commit 3d58dc6 into main Apr 4, 2024
1 of 2 checks passed
@jibel jibel deleted the docs_add_firewall_rules branch April 4, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants