maint(ci): Upgrade to Go 1.22.0 #667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Go 1.22.0 for-loop variables are scoped per iteration Closures created in for-loops are guaranteed to have distinct variables Thus tests no longer need to do the sttutering copy `tc := tc`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #667 +/- ##
==========================================
- Coverage 86.46% 85.20% -1.27%
==========================================
Files 87 90 +3
Lines 5616 5703 +87
==========================================
+ Hits 4856 4859 +3
- Misses 622 707 +85
+ Partials 138 137 -1 ☔ View full report in Codecov by Sentry. |
|
Closing since didrocks is working on it as well and made more progress as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade modules, workspace and package to Go 1.22.0 and remove loop closure variable redeclaration.
UDENG-2454