Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix auto-update wsl-pro-service not mod-tidying #413

Merged
merged 5 commits into from
Nov 20, 2023
Merged

ci: Fix auto-update wsl-pro-service not mod-tidying #413

merged 5 commits into from
Nov 20, 2023

Conversation

EduardGomezEscandell
Copy link
Contributor

Some fixes

  • Go-getting without mod-tidying was breaking workflows.
  • We were using a hand-crafted diff detector. We now use desktop-engineering's.
  • The WSL-Pro-Service was hard-coded in the action rather than using ${{ inputs.module }}.

@EduardGomezEscandell EduardGomezEscandell self-assigned this Nov 20, 2023
@EduardGomezEscandell
Tidy WSL-Pro-Service
9159f53 
This fixes the WSL Pro Service which was broken by the action being
fixed here. It was broken in
#410.
@EduardGomezEscandell EduardGomezEscandell mentioned this pull request Nov 20, 2023
Merged
@EduardGomezEscandell EduardGomezEscandell marked this pull request as ready for review November 20, 2023 11:34
CarlosNihelton
CarlosNihelton approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@EduardGomezEscandell EduardGomezEscandell merged commit 514d83f into main Nov 20, 2023
26 checks passed
@EduardGomezEscandell EduardGomezEscandell deleted the fix-autoupdate-wsl-pro-service branch November 20, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosNihelton CarlosNihelton CarlosNihelton approved these changes

@didrocks didrocks Awaiting requested review from didrocks

Assignees

@EduardGomezEscandell EduardGomezEscandell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EduardGomezEscandell @CarlosNihelton