-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(2e2): fix e2e build deb tests #397
Conversation
We need latest golang-1.21 in mantic for now. Allow using an overlay ppa to prepare an image for it, letting the whole deb build action generic. Use the ubuntu-desktop as a POC for now.
ensure we don’t use https to avoid having to install ca-certificates on the build system, which will skew the "no Internet access" test. The repo is still signed.
go mod tidy failing is fixed in PR #396 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Note that the full QA-Azure workflow did not run, as the test on Azure job was cancelled. Still, this PR's aim is limited to the Build Debian action, so I think we're good to go.
If the tests fail, that needs to be solved in a separate PR.
Right, see the first run where one test failed, mind creating a card for it? (could be flaky, but needs then investigation): |
Ubuntu is lagging in term of golang CI version. Consequently, we can’t both have govulncheck passing due to security issue and be able to build it in our CI (with Internet cut off).
Use then an overlay ppa to build requirements there not yet in the distro, by using a special container with that version to not change the generic action.
Ensure we still don’t pollute the end system with ca-certificates for offline install (we don’t want Go to auto-update)
UDENG-1722