Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(2e2): fix e2e build deb tests #397

Merged
merged 3 commits into from
Nov 14, 2023
Merged

ci(2e2): fix e2e build deb tests #397

merged 3 commits into from
Nov 14, 2023

Conversation

didrocks
Copy link
Collaborator

@didrocks didrocks commented Nov 14, 2023

Ubuntu is lagging in term of golang CI version. Consequently, we can’t both have govulncheck passing due to security issue and be able to build it in our CI (with Internet cut off).

Use then an overlay ppa to build requirements there not yet in the distro, by using a special container with that version to not change the generic action.
Ensure we still don’t pollute the end system with ca-certificates for offline install (we don’t want Go to auto-update)

UDENG-1722

We need latest golang-1.21 in mantic for now. Allow using an overlay ppa
to prepare an image for it, letting the whole deb build action generic.
Use the ubuntu-desktop as a POC for now.
ensure we don’t use https to avoid having to install ca-certificates on the
build system, which will skew the "no Internet access" test. The repo is
still signed.
@didrocks didrocks changed the title Fix e2e build deb tests ci(2e2): fix e2e build deb tests Nov 14, 2023
@didrocks didrocks marked this pull request as ready for review November 14, 2023 08:58
@didrocks
Copy link
Collaborator Author

go mod tidy failing is fixed in PR #396

Copy link
Contributor

@EduardGomezEscandell EduardGomezEscandell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Note that the full QA-Azure workflow did not run, as the test on Azure job was cancelled. Still, this PR's aim is limited to the Build Debian action, so I think we're good to go.

If the tests fail, that needs to be solved in a separate PR.

@didrocks
Copy link
Collaborator Author

Note that the full QA-Azure workflow did not run, as the test on Azure job was cancelled. Still, this PR's aim is limited to the Build Debian action, so I think we're good to go.
If the tests fail, that needs to be solved in a separate PR.

Right, see the first run where one test failed, mind creating a card for it? (could be flaky, but needs then investigation):
--- FAIL: TestPurchase/Success_when_applying_pro_token_after_registration (69.59s) in https://github.com/canonical/ubuntu-pro-for-windows/actions/runs/6860326629/job/18654169164

@didrocks didrocks merged commit b2050bb into main Nov 14, 2023
32 of 37 checks passed
@didrocks didrocks deleted the fix_deb_build branch November 14, 2023 09:19
EduardGomezEscandell added a commit that referenced this pull request Nov 14, 2023
…400)

The key value in which the Ubuntu Pro token is stored was changed in PR
#369 from `ProTokenOrg` to `UbuntuProToken`.

This error went unnoticed because the E2E tests were not working until
#397.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants