ci: Reduce amount of workflows #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduardGomezEscandell
force-pushed
the
fewer-gh-workflows
branch
4 times, most recently
from
1c90626 to
71c225b
Compare
EduardGomezEscandell
force-pushed
the
fewer-gh-workflows
branch
3 times, most recently
from
518df3a to
94be31b
Compare
|
Failing run is fixed in #400 |
This'll reduce the number of workflows being launched, avoiding or at least mitigating GitHub's throttling.
It just looks nicer
Most of the steps were repeated with the Flutter QA action, so I removed them. Then the action became small enough that it made no sense to have it separate from the workflow.
Almost irrelevant change, it changes the name of the workflow: - Before: Go Quality Checks (windows, windows-agent) - After: Go Quality Checks (windows-agent, windows) This means that when there is no space, Github will display: - Before: Go Quality Checks (windows, ... - After: Go Quality Checks (windows-ag... Small change, but the module is usually more relevant than the platform.
It's just more readable.
EduardGomezEscandell
force-pushed
the
fewer-gh-workflows
branch
from
94be31b to
4f375b6
Compare
|
Putting this idea on hold for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Flutter and Go QA is separated into two jobs: one with static checks (linting, vulnerability checking, generation, etc.) and a second one with tests.
We can remove redundant work and the total number of jobs by simply merging these.
We can skip tests when modifying irrelevant files.
So far, we've gone from 35 to 25 jobs.
UDENG-1715