Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Upgrade to Go 1.21.4 #389

Merged
merged 2 commits into from
Nov 8, 2023
Merged

maint: Upgrade to Go 1.21.4 #389

merged 2 commits into from
Nov 8, 2023

Conversation

EduardGomezEscandell
Copy link
Contributor

@EduardGomezEscandell EduardGomezEscandell commented Nov 8, 2023

Upades Go to 1.21.4 and removes the old workaround around the fact that golang-1.21-go is behind. Not because it is solved, but rather because the workaround does not work.

This workaround does not work, so no need to have it here anymore.
@EduardGomezEscandell EduardGomezEscandell marked this pull request as ready for review November 8, 2023 09:54
Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unfortunate that the workaround proved to be useful for a very short amount of time.
Thanks for removing it.

@EduardGomezEscandell EduardGomezEscandell merged commit 5899a22 into main Nov 8, 2023
34 of 35 checks passed
@EduardGomezEscandell EduardGomezEscandell deleted the go-1.21.4 branch November 8, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants