fix(windows-agent): Don't spam contract server #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduardGomezEscandell
force-pushed
the
dont-spam-contract-server
branch
2 times, most recently
from
e993d02 to
ef71b77
Compare
didrocks
requested changes
Nov 16, 2023
We don't need to querry the contract server if whe have a non-expired, store-backed Ubuntu Pro token.
This is necessary to test the function with mocked back-ends for the contract server and Microsoft Store.
These tests were written before we had any mocks for the MS store or the Contract server. The previous commits significantly change the implementation of the FetchMicrosoftStoreSubscription function, so it is now a great time to flesh out its tests with the new mocks.
EduardGomezEscandell
force-pushed
the
dont-spam-contract-server
branch
from
ef71b77 to
a0a349e
Compare
|
Rebased main, changes start now: |
EduardGomezEscandell
force-pushed
the
dont-spam-contract-server
branch
from
2110b04 to
a1f5c15
Compare
EduardGomezEscandell
force-pushed
the
dont-spam-contract-server
branch
from
a1f5c15 to
b810489
Compare
EduardGomezEscandell
added a commit
that referenced
this pull request
Nov 20, 2023
Seems like -1<<64 is not a valid timestamp. Let's just throw instead of returning a dummy number. The Go wrapper already catches the ErrNotSubscribed exception. Let's wait for #375 since the new behaviour is easier to reason about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't need to talk to the contracts server back-end if the registry already contains a pro token fetched from them. Rather, we should wait until our subscription expires, then get a new token (or more likely: the same token with an extended expiration date, this is up to the CS team).
UDENG-1667