Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows-agent): Fix panic due to early closure of database #368

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix(windows-agent): Fix panic due to early closure of database #368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion windows-agent/internal/proservices/proservices.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,13 @@ func New(ctx context.Context, args ...Option) (s Manager, err error) {
if err != nil {
return s, err
}
defer db.Close(ctx)
defer func() {
// Close DB if we return error
// Otherwise, it'll be closed in the call to Manager.Stop
if err != nil {
db.Close(ctx)
}
}()

if err := conf.UpdateRegistrySettings(ctx, opts.cacheDir, db); err != nil {
log.Warningf(ctx, "Could not update registry settings: %v", err)
Expand Down
Loading