-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Landscape): Hostagent URL moved to Landscape config file #365
Conversation
591b8ac
to
d11c67c
Compare
71a3f2d
to
d8ba340
Compare
97602ef
to
eec6019
Compare
Just to prove that the host section is stripped
d8ba340
to
3a36296
Compare
3a36296
to
5687a7f
Compare
5687a7f
to
5c2f99c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions, overall good, but I think we can make administrator’s life a little bit easier :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
I was too excited to merge and didn't squash commits :S |
The landscape client config currently needs at least three fields:
There is another registry key right now called LandscapeAgentURL which is used for the Windows-Agent gRPC connection. It would make more sense to put this information in the config as well, for example:
The host section is removed before writing the file to
/etc/landscape/client.conf
.In the future, we'll have to change the default value of
host/url
. It defaults to empty string both before and after this PR. We'd want it to default to Canonical's URL. This has been captured in Jira card 1687.UDENG-1644