feat(Landscape): Apply new Landscape config changes to pre-existing distros #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduardGomezEscandell
changed the base branch from
main
to
landscape-client-hostagent-uid
|
Waiting on #360 before setting it as ready |
EduardGomezEscandell
force-pushed
the
landscape-client-hostagent-uid
branch
from
9cbf554 to
c8b3916
Compare
EduardGomezEscandell
force-pushed
the
cheksum-landscape
branch
from
7d8f649 to
3d3429a
Compare
EduardGomezEscandell
force-pushed
the
cheksum-landscape
branch
from
3d3429a to
591b8ac
Compare
|
Force-pushed to rebase main after #360 |
EduardGomezEscandell
requested review from
didrocks
and removed request for
didrocks
didrocks
requested changes
Oct 26, 2023
EduardGomezEscandell
force-pushed
the
cheksum-landscape
branch
from
591b8ac to
d11c67c
Compare
|
New commits start at Rename acc -> errs |
didrocks
reviewed
Oct 26, 2023
didrocks
approved these changes
Oct 26, 2023
This should be a fixup to the commit before the previous one, but with the migration from proServices to Config, it becomes too messy. Fixes: - Rename acc -> errs - Rename valueIsNew to hasChanged - Fix typo in config - Remove endline when serializing Landscape We treat 'empty string' as a special value. With that \n there, the string would never be empty!
Say goodbye to a weird deferred function and an unnecessary goroutine
EduardGomezEscandell
force-pushed
the
cheksum-landscape
branch
from
97602ef to
eec6019
Compare
|
Force-pushed to clean up history. No changes to code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Landscape config is only applied to newly discovered distros (as a provisioning task). The idea is to apply it also to pre-existing distros, similar to what we do with the Pro Token.
UDENG-1602