Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gh-actions): Fix rate limitation in GRPC setup action #354

Closed
wants to merge 3 commits into from
Closed

fix(gh-actions): Fix rate limitation in GRPC setup action #354

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ace254a
Point to feature branch in Desktop Eng repository
EduardGomezEscandell Oct 23, 2023
c5ddac5
Disable all GITHUB_TOKEN permissions
EduardGomezEscandell Oct 23, 2023
c362fda
"Enable contents: read"
EduardGomezEscandell Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/qa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ jobs:
needs-flutter: true

runs-on: ${{ matrix.os }}-latest
permissions:
contents: read
steps:
- name: Set up git
# This step needs to be done before checkout so that the checkout respects clrf
Expand Down Expand Up @@ -64,8 +66,9 @@ jobs:
run: |
dart pub global activate protoc_plugin
- name: Quality check
uses: canonical/desktop-engineering/gh-actions/go/code-sanity@main
uses: canonical/desktop-engineering/gh-actions/go/code-sanity@setup-grpc-github-token
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea to play with the branch for a little while and then promote it to main? Because the related PR in the desktop engineering repo is still marked as draft.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. I'll set them as ready. I was making sure they were not merged, as these branch here needs to be pointed back to main before merging (same for the desktop engineering one).

with:
github-token: ${{ github.token}}
working-directory: ${{ matrix.subproject }}
go-tags: gowslmock
tools-directory: ${{ github.workspace }}/tools
Expand Down
Loading