feat(gui): Hide subscribe button udeng 1552 #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm stacking all my PR's on top of #338 because otherwise we fail on the vuln-check. |
CarlosNihelton
commented
Oct 16, 2023
gui/packages/ubuntupro/lib/pages/subscription_status/subscribe_now_page.dart
Show resolved
Hide resolved
CarlosNihelton
changed the title
CarlosNihelton
changed the title
EduardGomezEscandell
approved these changes
Oct 17, 2023
gui/packages/ubuntupro/lib/pages/subscription_status/subscription_status_model.dart
Outdated
Show resolved
Hide resolved
EduardGomezEscandell
previously approved these changes
Oct 17, 2023
CarlosNihelton
force-pushed
the
hide-subscribe-button-udeng-1552
branch
from
b4bf3f7 to
407ae02
Compare
For the private beta we've been advised to avoid the usage of MS Store purchase. The intended customers will use the scaled deployment. A greyed out button requires some explanation IMHO, Thus the tooltip. Only rendered in the disabled case.
But not yet e2e. We don't have one with the purchase scenario just yet.
... instead of a question.
CarlosNihelton
force-pushed
the
hide-subscribe-button-udeng-1552
branch
from
407ae02 to
b52f3ab
Compare
EduardGomezEscandell
dismissed
their stale review
The base branch was changed.
EduardGomezEscandell
approved these changes
Oct 18, 2023
CarlosNihelton
added a commit
that referenced
this pull request
Oct 21, 2023
…cks (#345) This PR augments the end to end tests by adding test cases for the purchasing workflow, following a similar recipe to the existing "organization provided" and 'manually input" token test scenarios. We add one more function to the `end_to_end_test.dart` file, handling the automation of the referred workflow, triggering a MS Store purchase action. That requires both the MS Store mock as well as the Contracts backend mock. Those are started by the test code (Go) prior to running the Ubuntu Pro for Windows app, ports are selected dynamically and the final addresses are supplied to the clients of the mock via environment variables. That, in turn, requires the MSIX to be built with the mock-aware store API, as well as a mock-aware CS backend URL (selected by a build tag). This is basically the contents I presented in one Desktop Team pulse review demo, but augmented with two simulated purchase failure scenarios (due CS backend outage or MS Store internal failure) and adapted to the changes introduced in #339 . One race condition in the storemockserver was found and fixed as part of this journey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the private beta we must avoid the MS Store purchase scenario. We agreed on a team meeting to do so using an environment variable as the toggle for that feature. The name choosen was
UP4W_ALLOW_STORE_PURCHASE.If set to a true-ish value, then the button is enabled as we are used to, otherwise the button is disabled and a tooltip gives a hint on why ("Coming soon" :) ). The tooltip is rendered on hover. There is no tooltip on the enabled case, even though the code shows there is a
Tooltipwidget there, it renders nothing when themessageparameter is empty.Here's how it looks when disabled:
