docs: Start using Read the Docs #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduardGomezEscandell
changed the title
EduardGomezEscandell
force-pushed
the
docs
branch
4 times, most recently
from
fd51c25 to
6f45600
Compare
EduardGomezEscandell
changed the title
EduardGomezEscandell
requested review from
a team
and removed request for
a team
CarlosNihelton
requested changes
Oct 11, 2023
The install document has been split in three.
They don't even pass the spell check :P
When attempting to edit a file on ReadTheDocs, it simply appends `github_folder` to the file name, so we need the trailing path separator.
Co-authored-by: Carlos Nihelton <[email protected]>
EduardGomezEscandell
force-pushed
the
docs
branch
from
5a34016 to
fba1a0b
Compare
|
Force-pushed to rebase main (I also snuck in a typo fix :P). |
EduardGomezEscandell
force-pushed
the
docs
branch
from
4373f67 to
8ae0e55
Compare
CarlosNihelton
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
LGTM 👍🏽
The deb buil CI failure is unrelated (and familiar), while the Go vulnerability checker alert is being handled in PR #338 , thus I think we are done with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highly recommended to look commits one by one. You can see a successful build here:
https://canonical-ubuntu-pro-for-windows.readthedocs-hosted.com/en/docs/#
UDENG-1551