Hide WinRT - Part II #290
Merged
Hide WinRT - Part II #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bit more pedantic header inclusion No coroutines
Now placed inside the service.
UserInfo related was moved to the context and to the header.
no more coroutines
DefineConstants is a C# property. For C++. it must be PreprocessorDefinitions under a ClCompile item. Also, the logic was twisted
CarlosNihelton
force-pushed
the
hide-winrt-part-II
branch
2 times, most recently
from
92ec533 to
e6c31d5
Compare
Removes coroutine and WinRT related headers, Updates stubs methods Removes no longer relevant test for user id size No test should isntantiate production Context
CarlosNihelton
force-pushed
the
hide-winrt-part-II
branch
from
e6c31d5 to
58d95c0
Compare
Token must not be empty
Idiomatic C++ C header inclusion :) Also fix ordering
CarlosNihelton
force-pushed
the
hide-winrt-part-II
branch
from
7d39b45 to
3cc36e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And season finale. With the following set of changes we are ready to work on the mock client API.
There was a bug in the DLL's vcxproj: The
DefineConstantsproperty is a C# thing. With VC++, we need to add aClCompileitem with thePreprocessorDefinitionsflag set. That's the way we do in WSL launcher end-to-end tests (https://github.com/ubuntu/WSL/blob/main/meta/UbuntuPreview/src/DistroLauncher/Preprocessor.props).Closes UDENG-1380