-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement workspace internal dependency updater #262
Conversation
49b516e
to
371e1e3
Compare
371e1e3
to
3c54edb
Compare
3c54edb
to
d2a2895
Compare
@didrocks Was thinking about this. All our PR commits belong to the main branch because we use merge commits, so is this really doing anything useful? It makes sense if you squash, since old commits become unreachable. But this is not the case here. |
d2a2895
to
800c11a
Compare
800c11a
to
f411abe
Compare
I think the action should be more fine-grained, as if look at any of those common deps for last commit if there is any update in the go files. Then, only trigger the update hook. However, thinking about it, the issue is about building the deb package, the rest is fine and good only be merged in the main branch. So, I’m wondering, could we trigger that on PR rather, check if there is any change in those common deps subdirectories, and in that case, run the action, and create a PR that is not automerged against your PR branch? WDYT? |
Only the WSL-Pro-Service needs to stay up-to-date. And we only need to update modules when these have changed
ebe0f2f
to
f9a8de4
Compare
The way it works now:
Then, only push the branch if anything changed. This method should considerably reduce spam, although it'll still have some false positives, such as when editing non-code files in the dependencies. If this ever happens to be an issue, we can filter diffs by file extension; however I doubt this'll ever become an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the internal vs external scripts and env variables passing silently as argument, I agree with the current approach.
.github/actions/update-workspace-dependencies/update-workspace-dependencies.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… and using that opportunity to clean up some trailing spaces, I see you! :)
This workflow will keep internal dependencies updated.
UDENG-267
PS: Sorry for the force-pushing. I was testing commit signing 🤭