[GUI] Notify purchase #260
Conversation
Otherwise clients would need two imports to make use of this plugin: ```dart import 'package:p4w_ms_store/p4w_ms_store.dart'; import 'package:p4w_ms_store/p4w_ms_store_platform_interface.dart'; ```
Silly to call AppLocalizations.of(context) if we already did that before and even saved it in a variable.
Now it: - notifies the agent on success; - returns the purchase status on error; - catches generic Exception's;
Snackbars are shown when the purchase completes A callback is offered for when the purchase is sucessful. Tests exercise both ways
The callback will notify the top level app of the new SubscriptionInfo. That causes a complete page rebuild. Going to the page matching the MS Store managed subscription status. On error nothing will change.
The service locator state is kept between test cases.
The change is too abrupt otherwise.
It would appear together with the new screen. Thus useless.
Since it's a callback after the purchase completes. The user will be already subscribed.
CarlosNihelton
force-pushed
the
notify-purchase-udeng-1254
branch
4 times, most recently
from
5823e56 to
da5b965
Compare
It appears that the agent is crashing. GrpcError might be thrown before post-morten tests complete. Integration tests report error when such happens.
CarlosNihelton
force-pushed
the
notify-purchase-udeng-1254
branch
from
da5b965 to
a269734
Compare
|
For now I'm amending the fact that the agent may crash after starting with just a try-catch, so we can succeed with the integration tests. I captured another task to properly handle the possibility of a generic agent crash. |
| @@ -25,7 +28,24 @@ class SubscribeNowPage extends StatelessWidget { | |||
| mainAxisAlignment: MainAxisAlignment.start, | |||
| children: [ | |||
| ElevatedButton( | |||
| onPressed: model.purchaseSubscription, | |||
| onPressed: () async { | |||
| // - Display errors | ||
| Future<void> purchaseSubscription() async { | ||
| await P4wMsStore().purchaseSubscription('9P25B50XMKXT'); | ||
| /// Triggers a purchase transaction via MS Store. |
There was a problem hiding this comment.
... and here are the motto for this PR.
All the rest is pretty much dealing with the consequences of those additions: adding more test cases, updating the existing ones, regenerating mocks, adding more localizable strings etc.
gui/packages/ubuntupro/lib/pages/subscription_status/subscription_status_model.dart
Show resolved
Hide resolved
It looks nicer indeed (I even updated the screenshots). I cannot go too far with padding, though, otherwise the |
Looks great! |
This follows on the PR #246 adding the
gRPCcall in the client side to notify the agent of a successful purchase.The
SubscribeNowPageis now capable of displaying feedback according to the outcome of that transaction. A callback argument will be called if the transaction completes successfully. That allows the upper level to react, by updating the app'sValueNotifier<SusbcriptionInfo>object, effectively causing this page to leave the stage for a page matching the newSubscriptinInfo, which is production must be the MS Store managed subscription status page.The UI element chosen for feedback on error is the
SnackBar. Yaru changes it's style a little bit, so don't feel surprised by the rounded widget.One integration test case was added to exercise that feedback. The "successful" test case cannot yet complete, because the background agent crashes when attempting to talk to the MS API. That will only be definitively addressed when the MS Store mock becomes available. On the GUI side we mock the binary messenger, so all Dart code is exercised when attempting to talk to the MS Store plugin, but the native code is skipped. Same as before.
Some screenshots of how it looks:
Fixes UDENG-1254