Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update documentation screenshots #1031

Merged
merged 2 commits into from
Dec 19, 2024
Merged

docs: Update documentation screenshots #1031

merged 2 commits into from
Dec 19, 2024

Conversation

ashuntu
Copy link
Collaborator

@ashuntu ashuntu commented Dec 19, 2024

Updates the screenshots for the Ubuntu Pro GUI app in the docs to the most recent designs.

UDENG-5685

@ashuntu ashuntu self-assigned this Dec 19, 2024
@ashuntu ashuntu requested a review from edibotopic December 19, 2024 16:57
@ashuntu ashuntu marked this pull request as ready for review December 19, 2024 16:57
@ashuntu ashuntu requested a review from a team as a code owner December 19, 2024 16:57
@ashuntu
Copy link
Collaborator Author

ashuntu commented Dec 19, 2024 •
edited
Loading

I don't think the CI failure is a result of these changes.

CarlosNihelton
CarlosNihelton approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this!

edibotopic
edibotopic requested changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@edibotopic edibotopic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good but I have one query on the status page after configuration through the registry.

Also, I just re-ran the docs CI and it fixed the CI error -- sometimes it needs some massaging 🥲

docs/howto/assets/status-complete-registry.png Show resolved Hide resolved
@ashuntu
Update registry status image
bd6b6cb 
When set via the registry, no action buttons will be shown, so the screenshot should reflect this.
edibotopic
edibotopic approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@edibotopic edibotopic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now. Thanks for this, Ashton!

@ashuntu ashuntu merged commit d98990d into main Dec 19, 2024
3 checks passed
@ashuntu ashuntu deleted the update-doc-screenshots branch December 19, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosNihelton CarlosNihelton CarlosNihelton approved these changes

@edibotopic edibotopic edibotopic approved these changes

Assignees

@ashuntu ashuntu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashuntu @CarlosNihelton @edibotopic