Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint(gui-ubuntupro): Remove generated mock files #1018

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

ashuntu
Copy link
Collaborator

@ashuntu ashuntu commented Dec 18, 2024

Removes all generated *.mocks.dart files from the ubuntupro apps. These were removed since they aren't necessarily stable and can be generated locally and in CI anyway by running dart run build_runner build. This also means that developers no longer have to make sure to regenerate mocks when modifying the tests or models.


UDENG-5592

These can be generated by the developer locally with dart run build_runner build
@ashuntu ashuntu self-assigned this Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (aea00b5) to head (94d37ea).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1018      +/-   ##
==========================================
+ Coverage   89.10%   89.11%   +0.01%     
==========================================
  Files         112      112              
  Lines        7498     7498              
==========================================
+ Hits         6681     6682       +1     
+ Misses        639      638       -1     
  Partials      178      178              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashuntu ashuntu marked this pull request as ready for review December 18, 2024 21:04
@ashuntu ashuntu requested a review from a team as a code owner December 18, 2024 21:04
@ashuntu ashuntu changed the title fix(gui-ubuntupro): Remove generated mock files maint(gui-ubuntupro): Remove generated mock files Dec 19, 2024
Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to align the practices of the Apps team.

@ashuntu ashuntu merged commit 3d9a930 into main Dec 19, 2024
39 checks passed
@ashuntu ashuntu deleted the remove-mocks branch December 19, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants