Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows-agent): Check that IPs are convertible to ipv4 #1006

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

ashuntu
Copy link
Collaborator

@ashuntu ashuntu commented Dec 6, 2024

If the system receives an IPv6 address, then running the agent with mocks (for example, when running integration tests) can result in panics. This fixes that issue by checking if the IP is convertible to Ipv4.

For context, this came up when I attempted to run the Flutter integration tests on a network and host that technically support IPv6.

If the system receives an IPv6 address, then running the agent with mocks (for example, when running integration tests) can result in panics.

Co-authored-by: Carlos Nihelton <[email protected]>
@ashuntu ashuntu self-assigned this Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.25%. Comparing base (b4a5f0d) to head (bd7ec29).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1006      +/-   ##
==========================================
- Coverage   89.28%   89.25%   -0.03%     
==========================================
  Files         110      110              
  Lines        7520     7520              
==========================================
- Hits         6714     6712       -2     
- Misses        627      630       +3     
+ Partials      179      178       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashuntu ashuntu changed the title FIx: Check that IPs are convertible to ipv4 fix(windows-agent): Check that IPs are convertible to ipv4 Dec 6, 2024
@ashuntu ashuntu marked this pull request as ready for review December 6, 2024 19:09
@ashuntu ashuntu requested a review from a team as a code owner December 6, 2024 19:09
Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the finding!

@ashuntu ashuntu merged commit 3564f35 into main Dec 6, 2024
36 checks passed
@ashuntu ashuntu deleted the check-ip4 branch December 6, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants