Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Landscape): Hostagent URL moved to Landscape config file #365

Merged
merged 10 commits into from
Oct 27, 2023

Conversation

EduardGomezEscandell
Copy link
Contributor

@EduardGomezEscandell EduardGomezEscandell commented Oct 26, 2023

The landscape client config currently needs at least three fields:

[client]
url = https://landscape.canonical.com/message-system
ping_url = http://landscape.canonical.com/ping
account_name = dummy

There is another registry key right now called LandscapeAgentURL which is used for the Windows-Agent gRPC connection. It would make more sense to put this information in the config as well, for example:

[host]
url = https://landscape.canonical.com/hostagent

[client]
url = https://landscape.canonical.com/message-system
ping_url = http://landscape.canonical.com/ping
account_name = dummy

The host section is removed before writing the file to /etc/landscape/client.conf.


In the future, we'll have to change the default value of host/url. It defaults to empty string both before and after this PR. We'd want it to default to Canonical's URL. This has been captured in Jira card 1687.


UDENG-1644

@EduardGomezEscandell EduardGomezEscandell self-assigned this Oct 26, 2023
@EduardGomezEscandell EduardGomezEscandell force-pushed the hostagent-url-in-file branch 3 times, most recently from 71a3f2d to d8ba340 Compare October 26, 2023 11:24
Base automatically changed from cheksum-landscape to main October 26, 2023 12:35
@EduardGomezEscandell EduardGomezEscandell marked this pull request as ready for review October 26, 2023 12:40
@EduardGomezEscandell EduardGomezEscandell requested review from didrocks and CarlosNihelton and removed request for didrocks October 26, 2023 14:48
Copy link
Collaborator

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions, overall good, but I think we can make administrator’s life a little bit easier :)

docs/03-restart.md Show resolved Hide resolved
docs/04-enable-pro.md Outdated Show resolved Hide resolved
docs/05-attach-landscape.md Outdated Show resolved Hide resolved
docs/03-restart.md Outdated Show resolved Hide resolved
wsl-pro-service/internal/system/landscape.go Show resolved Hide resolved
Copy link
Collaborator

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@EduardGomezEscandell EduardGomezEscandell merged commit e71aab4 into main Oct 27, 2023
33 of 34 checks passed
@EduardGomezEscandell EduardGomezEscandell deleted the hostagent-url-in-file branch October 27, 2023 08:26
@EduardGomezEscandell
Copy link
Contributor Author

I was too excited to merge and didn't squash commits :S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants