fix(gh-actions): Fix rate limitation in GRPC setup action #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduardGomezEscandell
force-pushed
the
fix-grpc-rate-limiting
branch
from
4a3f9ac to
ace254a
Compare
|
We only need See a failed run with no permissions: https://github.com/canonical/ubuntu-pro-for-windows/actions/runs/6610766151 And a successful run with only |
CarlosNihelton
approved these changes
Oct 24, 2023
| @@ -64,8 +66,9 @@ jobs: | |||
| run: | | |||
| dart pub global activate protoc_plugin | |||
| - name: Quality check | |||
| uses: canonical/desktop-engineering/gh-actions/go/code-sanity@main | |||
| uses: canonical/desktop-engineering/gh-actions/go/code-sanity@setup-grpc-github-token | |||
There was a problem hiding this comment.
Is the idea to play with the branch for a little while and then promote it to main? Because the related PR in the desktop engineering repo is still marked as draft.
There was a problem hiding this comment.
Fair point. I'll set them as ready. I was making sure they were not merged, as these branch here needs to be pointed back to main before merging (same for the desktop engineering one).
|
Closing until we find a solution we are happy with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to canonical/desktop-engineering#13