Dispose of TextEditingController

canonical · Dec 17, 2024 · af57297 · af57297
1 parent 99d9134
commit af57297
Showing 1 changed file with 35 additions and 24 deletions.
diff --git a/gui/packages/ubuntupro/lib/pages/subscribe_now/subscribe_now_page.dart b/gui/packages/ubuntupro/lib/pages/subscribe_now/subscribe_now_page.dart
@@ -14,13 +14,44 @@ import '/pages/widgets/page_widgets.dart';
 import 'subscribe_now_model.dart';
 import 'subscribe_now_widgets.dart';
 
-class SubscribeNowPage extends StatelessWidget {
-  SubscribeNowPage({super.key, required this.onSubscriptionUpdate});
+class SubscribeNowPage extends StatefulWidget {
+  const SubscribeNowPage({super.key, required this.onSubscriptionUpdate});
 
   final void Function(SubscriptionInfo) onSubscriptionUpdate;
 
+  @override
+  State<SubscribeNowPage> createState() => _SubscribeNowPageState();
+
+  static Widget create(BuildContext context) {
+    final client = getService<AgentApiClient>();
+    final storePurchaseIsAllowed =
+        Wizard.of(context).routeData as bool? ?? false;
+
+    return ChangeNotifierProvider<SubscribeNowModel>(
+      create: (context) => SubscribeNowModel(
+        client,
+        isPurchaseAllowed: storePurchaseIsAllowed,
+      ),
+      child: SubscribeNowPage(
+        onSubscriptionUpdate: (info) {
+          final src = context.read<ValueNotifier<ConfigSources>>();
+          src.value.proSubscription = info;
+          Wizard.of(context).next();
+        },
+      ),
+    );
+  }
+}
+
+class _SubscribeNowPageState extends State<SubscribeNowPage> {
   final controller = TextEditingController();
 
+  @override
+  void dispose() {
+    controller.dispose();
+    super.dispose();
+  }
+
   @override
   Widget build(BuildContext context) {
     final model = context.watch<SubscribeNowModel>();
@@ -70,7 +101,7 @@ class SubscribeNowPage extends StatelessWidget {
                         ),
                       );
                     },
-                    ifRight: onSubscriptionUpdate,
+                    ifRight: widget.onSubscriptionUpdate,
                   );
                 },
           child: Text(lang.getUbuntuPro),
@@ -92,30 +123,10 @@ class SubscribeNowPage extends StatelessWidget {
   }
 
   void trySubmit(SubscribeNowModel model) {
-    model.applyProToken(model.token!).then(onSubscriptionUpdate);
+    model.applyProToken(model.token!).then(widget.onSubscriptionUpdate);
     model.clearToken();
     controller.clear();
   }
-
-  static Widget create(BuildContext context) {
-    final client = getService<AgentApiClient>();
-    final storePurchaseIsAllowed =
-        Wizard.of(context).routeData as bool? ?? false;
-
-    return ChangeNotifierProvider<SubscribeNowModel>(
-      create: (context) => SubscribeNowModel(
-        client,
-        isPurchaseAllowed: storePurchaseIsAllowed,
-      ),
-      child: SubscribeNowPage(
-        onSubscriptionUpdate: (info) {
-          final src = context.read<ValueNotifier<ConfigSources>>();
-          src.value.proSubscription = info;
-          Wizard.of(context).next();
-        },
-      ),
-    );
-  }
 }
 
 extension PurchaseStatusl10n on PurchaseStatus {