Skip to content

Commit

Permalink
Fix MSBuild PreprocessorDefinitions
Browse files Browse the repository at this point in the history
DefineConstants is a C# property.
For C++. it must be PreprocessorDefinitions under a ClCompile item.
Also, the logic was twisted
  • Loading branch information
CarlosNihelton committed Sep 18, 2023
1 parent ed6b228 commit 23084ab
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions msix/storeapi/storeapi.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,11 @@
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<PropertyGroup Label="UserMacros" />
<PropertyGroup Label="Mock API" Condition="'$(UP4W_TEST_WITH_MS_STORE_MOCK)' == ''">
<DefineConstants>UP4W_TEST_WITH_MS_STORE_MOCK</DefineConstants>
</PropertyGroup>
<ItemDefinitionGroup Label="Mock API" Condition="'$(UP4W_TEST_WITH_MS_STORE_MOCK)' != ''">
<ClCompile>
<PreprocessorDefinitions>UP4W_TEST_WITH_MS_STORE_MOCK;%(PreProcessorDefinitions)</PreprocessorDefinitions>
</ClCompile>
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
<ClCompile>
<WarningLevel>Level3</WarningLevel>
Expand Down

0 comments on commit 23084ab

Please sign in to comment.