feat: check for gstreamer or pipewire libraries before setting them #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenvandine
requested review from
sergiusens and
sergio-costas
and removed request for
sergiusens
|
@soumyaDghosh What is the problem that this patch fixes? In which cases can those variables be previously defined? |
|
In cases when the snap is building gstreamer or pipewire from and shipping within the snap, for eg, firefox, chromium, clapper |
|
@kenvandine I don't think I am the right person to review this |
|
This needs to be merged to fix https://launchpad.net/bugs/2074358. @jhenstridge or @sergio-costas, can you help reviewing this? |
nteodosio
reviewed
Jul 29, 2024
sergio-costas
requested changes
Jul 29, 2024
soumyaDghosh
force-pushed
the
main
branch
2 times, most recently
from
9a45a96 to
831333e
Compare
This PR allows snaps to use their own set of pipewire or gstreamer libraries.
|
+1, thank you! |
sergio-costas
approved these changes
Nov 27, 2024
|
@nteodosio I was doing some maintenance checks and found this awaiting for my approval... Is this still required? |
|
I'd say yes. I worked around it in Chromium, but this is sure to bite someone, somewhen if not merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows snaps to use their own set of pipewire or gstreamer libraries.