Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Store authentication keys in a separate database #55

Merged
merged 3 commits into from
Feb 26, 2024
Merged

feat: Store authentication keys in a separate database #55

merged 3 commits into from
Feb 26, 2024

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Feb 20, 2024 •
edited
Loading

Description

The upstream PR requires changes in the charm to use the second database.
The upstream PR is merged. This PR has a dependency to canonical/sdcore-udr-rock#13 which updates webconsole image.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@gatici gatici requested a review from a team as a code owner February 20, 2024 20:33
@gatici gatici changed the title Store authentication keys in a separate database feat: Store authentication keys in a separate database Feb 20, 2024
gruyaume
gruyaume reviewed Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@gruyaume gruyaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a minor comment plus let's make sure this is tested end to end with the gnbsim before merging this here.

src/charm.py Outdated Show resolved Hide resolved
@gatici gatici force-pushed the TELCO-1001-store-authetication-keys-in-separate-dbs branch from 8919e2a to b657fcc Compare February 23, 2024 13:55
@gatici gatici force-pushed the TELCO-1001-store-authetication-keys-in-separate-dbs branch from b657fcc to 4074067 Compare February 23, 2024 15:40
@gatici gatici requested a review from gruyaume February 23, 2024 17:58
@gatici gatici merged commit 3e20b87 into main Feb 26, 2024
10 checks passed
@gatici gatici deleted the TELCO-1001-store-authetication-keys-in-separate-dbs branch February 26, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruyaume gruyaume gruyaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gatici @gruyaume