Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NMS integration with TLS #368

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

patriciareinoso
Copy link
Contributor

Description

This PR adds the NMS integration with the TLS to the integration tests.
TLS certificates integration is mandatory for NMS and the NMS charm does not share the webui address until this relation exists.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@patriciareinoso patriciareinoso requested a review from a team as a code owner November 18, 2024 17:25
@patriciareinoso patriciareinoso enabled auto-merge (squash) November 18, 2024 17:43
@patriciareinoso patriciareinoso merged commit 5b17e98 into main Nov 18, 2024
21 of 23 checks passed
@patriciareinoso patriciareinoso deleted the TELCO-1408-add-tls-integration-nms branch November 18, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants