Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Checks if certificate is already requested #26

Merged
merged 2 commits into from
Nov 15, 2023
Merged

fix: Checks if certificate is already requested #26

merged 2 commits into from
Nov 15, 2023

Conversation

saltiyazan
Copy link
Contributor

Adds unit tests cases

Description

Adds a guard in the certificates relation joined handler to check if the cert was already stored before requesting a new one.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@saltiyazan saltiyazan requested a review from a team as a code owner November 14, 2023 10:58
@saltiyazan saltiyazan changed the title Checks if certificate is already requested fix: Checks if certificate is already requested Nov 14, 2023
@saltiyazan saltiyazan merged commit 1a87c02 into main Nov 15, 2023
9 checks passed
@saltiyazan saltiyazan deleted the TELCO-872-fix-requests-certs-only-if-necessary branch November 15, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatici gatici gatici approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saltiyazan @gatici