Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce TLS Integration #20

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Conversation

dariofaccin
Copy link
Contributor

Description

Enforces TLS integration in the charm. Charm remains in blocked state until the certificates relation is created, and in waiting status until a certificate is stored.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@dariofaccin dariofaccin requested a review from a team as a code owner September 29, 2023 15:25
tests/integration/test_integration.py Outdated Show resolved Hide resolved
@DanielArndt DanielArndt mentioned this pull request Oct 4, 2023
7 tasks
@DanielArndt
Copy link
Member

@dariofaccin I didn't do anything here. I just re-ran it after the first build on my commit failed -- under the suspicion that maybe something cached on the runner. I'm not sure that makes any sense... but it succeeded this time...

@DanielArndt DanielArndt requested a review from gruyaume October 5, 2023 18:22
@dariofaccin dariofaccin merged commit 396997c into main Oct 6, 2023
8 checks passed
@dariofaccin dariofaccin deleted the TELCO-771-enforce-tls-integration branch October 6, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants