-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add read-only 'pod' property to Machine objects #245
Conversation
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
=======================================
Coverage 67.98% 67.99%
=======================================
Files 70 70
Lines 5726 5727 +1
Branches 988 988
=======================================
+ Hits 3893 3894 +1
Misses 1610 1610
Partials 223 223
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
=======================================
Coverage 67.98% 67.99%
=======================================
Files 70 70
Lines 5726 5727 +1
Branches 988 988
=======================================
+ Hits 3893 3894 +1
Misses 1610 1610
Partials 223 223
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This new property allows the client to know in which pod a virtual machine was commissioned (if any).
fea8c2c
to
8fd5ccc
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #245 +/- ##
=======================================
Coverage 69.16% 69.17%
=======================================
Files 73 73
Lines 5958 5959 +1
Branches 1336 1336
=======================================
+ Hits 4121 4122 +1
Misses 1607 1607
Partials 230 230
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
LGTM also, merging as tests have passed |
This new property allows the client to know in which pod a virtual machine was commissioned (if any). Very useful for building dependency trees between machines.