Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read-only 'pod' property to Machine objects #245

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

ittner
Copy link
Contributor

@ittner ittner commented Sep 18, 2020

This new property allows the client to know in which pod a virtual machine was commissioned (if any). Very useful for building dependency trees between machines.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2020

Codecov Report

Merging #245 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   67.98%   67.99%           
=======================================
  Files          70       70           
  Lines        5726     5727    +1     
  Branches      988      988           
=======================================
+ Hits         3893     3894    +1     
  Misses       1610     1610           
  Partials      223      223           
Impacted Files Coverage Δ
maas/client/viscera/machines.py 72.47% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 069e758...f3fb3ec. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #245 (f3fb3ec) into master (575d3f7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   67.98%   67.99%           
=======================================
  Files          70       70           
  Lines        5726     5727    +1     
  Branches      988      988           
=======================================
+ Hits         3893     3894    +1     
  Misses       1610     1610           
  Partials      223      223           
Impacted Files Coverage Δ
maas/client/viscera/machines.py 72.47% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94fe03e...c964794. Read the comment docs.

Copy link

@cpg1111 cpg1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This new property allows the client to know in which pod a virtual
machine was commissioned (if any).
@SK1Y101 SK1Y101 force-pushed the add-pod-property-to-machines branch from fea8c2c to 8fd5ccc Compare August 21, 2023 09:15
@codecov-commenter
Copy link

Codecov Report

Merging #245 (fea8c2c) into master (1ff28d5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head fea8c2c differs from pull request most recent head 8fd5ccc. Consider uploading reports for the commit 8fd5ccc to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   69.16%   69.17%           
=======================================
  Files          73       73           
  Lines        5958     5959    +1     
  Branches     1336     1336           
=======================================
+ Hits         4121     4122    +1     
  Misses       1607     1607           
  Partials      230      230           
Files Changed Coverage Δ
maas/client/viscera/machines.py 73.08% <100.00%> (+0.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SK1Y101
Copy link
Member

SK1Y101 commented Aug 21, 2023

LGTM also, merging as tests have passed

@SK1Y101 SK1Y101 merged commit 7c1374b into canonical:master Aug 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants