Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add alma8 and alma9 packer configs #207

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

lleyton
Copy link
Contributor

@lleyton lleyton commented Feb 12, 2024

These are mainly just copies of the Rocky configs, but with the Alma repos instead.

note: haven't personally tested these, yet

Copy link
Contributor

@alexsander-souza alexsander-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work, but the alma9 template need some changes.

basically just do the same changes done to alma8 to use the packer template file format and variable expansion.

alma9/Makefile Outdated Show resolved Hide resolved
alma9/README.md Outdated Show resolved Hide resolved
alma9/alma9.pkr.hcl Show resolved Hide resolved
alma9/alma9.pkr.hcl Show resolved Hide resolved
alma9/http/alma.ks.in Outdated Show resolved Hide resolved
@lleyton lleyton requested a review from alexsander-souza March 4, 2024 10:36
@lleyton
Copy link
Contributor Author

lleyton commented Mar 4, 2024

Just impled the suggestions, let me know if it looks good now

@SK1Y101
Copy link
Member

SK1Y101 commented Mar 4, 2024

Hi @lleyton, just hopping in to confirm that your alma9 changes allow the image to be built with the proxy settings as expected with the current packer version!

Copy link
Contributor

@alexsander-souza alexsander-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, lgtm

@alexsander-souza alexsander-souza merged commit 95ca529 into canonical:main Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants