Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get mirrors from the env #167

Merged

Conversation

alexsander-souza
Copy link
Contributor

make it easier to integrate with the build pipeline

make it easier to integrate with the build pipeline
Copy link
Contributor

@skatsaounis skatsaounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skatsaounis
Copy link
Contributor

Just a comment though: Is it valid to also add it to CentOS 8 stream?

@alexsander-souza
Copy link
Contributor Author

Just a comment though: Is it valid to also add it to CentOS 8 stream?

I think we could do it, and probably for other RH-based distros (e.g. Rocky). I'm going to push another PR with this once we unblock the build pipeline

@alexsander-souza alexsander-souza merged commit aef63ca into canonical:main Nov 28, 2023
1 check passed
@alexsander-souza alexsander-souza deleted the centos_get_mirror_from_env branch November 28, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants