Fixes for vmware-esxi builder and any builders that the fuse scripts. #131

ThinGuy · 2023-08-31T20:40:50Z

Changes to vmware-esxi to build ESXi 8.0b
Change any call that attempts fusermount -u to fusermount -z -u

- Set packer version to 1.9+ - Use latest packer plugin - Fix missing spaces in boot_cmd and use <spacebar> command - Change base RAM to 8GB - Change qemu -cpu arg from host to max to "Enables all features supported by the accelerator in the current host"

Instruct fusermount to perform a lazy unmounts to prevent image hanging on a device busy message

Have fusermount perform lazy unmounts to prevent hanging

…from device busy mesage

CodeBleu · 2023-08-31T23:38:20Z

@ThinGuy I was looking around to see if any newer forks had any updates in them to fix the fuse stuff, and possibly Fedora38 OS as well...or any Fedora Server for that matter. I then found your fork and was noticing you knocking stuff out. Appreciate it!

I'm assuming this will fix #126 ?

…l option (-e)

…rocessing

ThinGuy · 2023-09-01T21:08:01Z

@ThinGuy I was looking around to see if any newer forks had any updates in them to fix the fuse stuff, and possibly Fedora38 OS as well...or any Fedora Server for that matter. I then found your fork and was noticing you knocking stuff out. Appreciate it!

I'm assuming this will fix #126 ?

I hope so! Currently, rhel 9.2 builds clean but the installation hits the 30-minute timeout. Curtin runs without error, server is set up correctly, but it never tells MAAS that the installation is completed.

alexsander-souza

awesome job, but it needs some tweaks

alexsander-souza · 2023-09-05T18:29:55Z

vmware-esxi/KS.CFG

@@ -27,12 +27,12 @@ exec &> /var/log/maas.log
 set +e

 # Enable SSH
-# vim-cmd hostsvc/enable_ssh


we should keep this disabled, it may pose a security risk for some users and we don't have a good way to alert them of this change.

alexsander-souza · 2023-09-05T18:30:14Z

vmware-esxi/KS.CFG


 # Enable ESXi shell
-# vim-cmd hostsvc/enable_esx_shell
-# vim-cmd hostsvc/start_esx_shell
+vim-cmd hostsvc/enable_esx_shell


same as above, keep this disabled

alexsander-souza · 2023-09-05T18:56:57Z

rhel9/Makefile

@@ -10,7 +10,11 @@ export PACKER_LOG KS_PROXY
 all: rhel9.tar.gz

 check-deps:
-	dpkg -s libnbd-bin nbdkit packer fuse2fs > /dev/null
+	@if [ $(shell lsb_release -sr|cut -d. -f1) -le 20 ];then \


Suggested change

@if [ $(shell lsb_release -sr|cut -d. -f1) -le 20 ];then \

@if [ $(shell lsb_release -sr|cut -d. -f1) -ge 22 ];then \

dpkg -s libnbd-bin nbdkit packer fuse2fs > /dev/null; \

else \

dpkg -s libnbd0 nbdkit packer fuse2fs > /dev/null; \

fi

alexsander-souza · 2023-09-05T19:00:50Z

rhel9/README.md

@@ -8,7 +8,14 @@ The Packer template in this directory creates a RHEL 9 AMD64 image for use with

 * A machine running Ubuntu 22.04+ with the ability to run KVM virtual machines.
 * qemu-utils, libnbd-bin, nbdkit and fuse2fs
-* [Packer](https://www.packer.io/intro/getting-started/install.html), v1.8.0 or newer
+* packer - from Hashicorp repository, v1.9.0 or newer


keep the reference to Packer install page. It's easier to keep docs up to date if we rely on external resources.

alexsander-souza · 2023-09-05T19:01:41Z

ubuntu/Makefile

@@ -8,8 +8,11 @@ SUDO ?= sudo
 all: custom-cloudimg.tar.gz

 check-deps:
-	dpkg -s libnbd-bin nbdkit packer fuse2fs cloud-image-utils ovmf > /dev/null
-
+	@if [ $(shell lsb_release -sr|cut -d. -f1) -le 20 ];then \


see suggestion in the RHEL makefile above

alexsander-souza · 2023-09-05T19:02:38Z

vmware-esxi/Makefile

@@ -10,7 +10,11 @@ VENV := .ve
 all: vmware-esxi.dd.gz

 check-deps:
-	dpkg -s libnbd-bin nbdkit packer fusefat > /dev/null
+	@if [ $(shell lsb_release -sr|cut -d. -f1) -le 20 ];then \


see suggestion in the makefiles above

alexsander-souza · 2023-09-05T19:03:16Z

vmware-esxi/vmware-esxi.pkr.hcl

@@ -25,9 +25,9 @@ source "qemu" "esxi" {
  headless         = true
  iso_checksum     = "none"
  iso_url          = var.vmware_esxi_iso_path
-  memory           = 4096
+  memory           = 8192


it this really necessary?

when fuse-tar-root creates an tarball of \$ROOT_MOUNT it should exclude unix sockets (created by lxd, ssh, etc), otherwise these non-fatal errors are in the log: tar: ./tmp/ssh-7tMRv9PdwU/agent.1402: socket ignored tar: ./var/snap/lxd/common/lxd/unix.socket: socket ignored tar: ./var/snap/lxd/common/lxd-user/unix.socket: socket ignored

…launch Dialog

alexsander-souza · 2023-09-14T14:43:35Z

superseded by #137, #138, #139 and #140

ThinGuy added 21 commits August 31, 2023 10:30

Change to lazy unmount

316c44d

Don't check hardware/CPUs during packer image creation

75d8cb5

Update vmware-esxi.pkr.hcl

956a29e

- Set packer version to 1.9+ - Use latest packer plugin - Fix missing spaces in boot_cmd and use <spacebar> command - Change base RAM to 8GB - Change qemu -cpu arg from host to max to "Enables all features supported by the accelerator in the current host"

Missing trailing "." for packer init

7d441f3

Update fuse-nbd

8f3eb48

Instruct fusermount to perform a lazy unmounts to prevent image hanging on a device busy message

Update fuse-tar-root

df9cb08

Have fusermount perform lazy unmounts to prevent hanging

Have fusermount perform lazy unmounts to prevent image build hanging …

45b98f7

…from device busy mesage

Change directory to $HOME before performing cleanup functipon

564891b

Fix Requirements and packages

2e2e5bc

Make pre-reqs clearer

2c160d3

Enable ssh and ESXi shell by default

b9e9c69

Cleanup package requirements.

9fc46c5

Add note for snap-based MAAS users related to image location for uploads

1f1a5c6

Set minimum packer version and use packer qmeu pluging

b5871cc

Set min packer to 1.9, set updated qemu plugin, change cpu arg to max

0d5c0e6

Change libnbd-bin to libnbd0 for focal and bionic

66cd434

Use correct version of libnbd based on Ubuntu release

d62e566

Use correct version of libnbd depending on Ubuntu release

4c4511e

Fix tab issue

001e308

Fix tabs

d57589b

Use correct version of libnbd based on ubuntu release

406d8dd

ThinGuy added 8 commits August 31, 2023 17:20

If fuse fs still mounted, force unmount

d0b924c

force umount if fuse fs still mounted, remove "Exit immediately" shel…

a029356

…l option (-e)

Add trailing period (represents *.json or *.hcl) to packer init command

2c8fc47

Add how install packer from hashicorp repositories

afd0a89

Attempt to fix non-zero exit code

b3175b6

Fix non-zero exit code

9761506

Fix missing double quotes in boot_cmd string

6f13830

Fix missing double quote at end of systemMediaSize=min

1126242

ThinGuy added 3 commits August 31, 2023 18:14

cleanup boot_command by using <spacebar> characters

2dbf2f8

Remove "Exit Immediately" shell option and turn on verbose for post p…

58d1c11

…rocessing

Backout packer/qemu definitions due to duplicated lines in other hcl

a9c8918

ThinGuy added 5 commits September 2, 2023 09:44

Test if $TMP_DIR/boot is mounted and only unmount if necessary.

153586b

Test if $dev (${TMP_DIR}/p*) is mounted and only unmount if necessary.

1b2b9e8

Test if ${ROOT_MOUNT}{,dev} are mounted and unmount if necessary.

910723f

Remove "Exit immediately" shell, enable verbose

946d881

Enable verbose output for post.sh

9438dcf

alexsander-souza requested changes Sep 5, 2023

View reviewed changes

ThinGuy added 5 commits September 8, 2023 12:48

Use DEBIAN_FRONTEND=noninteractive to prevent debconf from trying to …

f1902eb

…launch Dialog

Use DEBIAN_FRONTEND=noninteractive so debconf does not try to use Dialog

cbfbee7

Use DEBIAN_FRONTEND=noninteractive to prevent debconf from using Dialog

a80d04a

Use DEBIAN_FRONTEND=noninteractive to prevent debconf from using Dialog

b842bed

alexsander-souza closed this Sep 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for vmware-esxi builder and any builders that the fuse scripts. #131

Fixes for vmware-esxi builder and any builders that the fuse scripts. #131

ThinGuy commented Aug 31, 2023

CodeBleu commented Aug 31, 2023

ThinGuy commented Sep 1, 2023

alexsander-souza left a comment

alexsander-souza Sep 5, 2023

alexsander-souza Sep 5, 2023

alexsander-souza Sep 5, 2023

alexsander-souza Sep 5, 2023

alexsander-souza Sep 5, 2023

alexsander-souza Sep 5, 2023

alexsander-souza Sep 5, 2023

alexsander-souza commented Sep 14, 2023

-	@if [ $(shell lsb_release -sr|cut -d. -f1) -le 20 ];then \
+	@if [ $(shell lsb_release -sr|cut -d. -f1) -ge 22 ];then \
+	  dpkg -s libnbd-bin nbdkit packer fuse2fs > /dev/null;  \
+	else \
+ 	  dpkg -s libnbd0 nbdkit packer fuse2fs > /dev/null; \
+ 	fi

Fixes for vmware-esxi builder and any builders that the fuse scripts. #131

Fixes for vmware-esxi builder and any builders that the fuse scripts. #131

Conversation

ThinGuy commented Aug 31, 2023

CodeBleu commented Aug 31, 2023

ThinGuy commented Sep 1, 2023

alexsander-souza left a comment

Choose a reason for hiding this comment

alexsander-souza Sep 5, 2023

Choose a reason for hiding this comment

alexsander-souza Sep 5, 2023

Choose a reason for hiding this comment

alexsander-souza Sep 5, 2023

Choose a reason for hiding this comment

alexsander-souza Sep 5, 2023

Choose a reason for hiding this comment

alexsander-souza Sep 5, 2023

Choose a reason for hiding this comment

alexsander-souza Sep 5, 2023

Choose a reason for hiding this comment

alexsander-souza Sep 5, 2023

Choose a reason for hiding this comment

alexsander-souza commented Sep 14, 2023