Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename paas_app_charmer -> paas_charm #5

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Conversation

javierdelapuente
Copy link
Collaborator

@javierdelapuente javierdelapuente commented Oct 11, 2024

Applicable spec:

Overview

Rationale

The goal of this PR is to rename paas-app-charmer to paas-charm (both the repo and the modules). The original repository is paas-app-charmer repo.

To be backward compatible, it is necessary to keep the following classes (see the templates in charmcraft):

  • paas_app_charmer.django.Charm
  • paas_app_charmer.fastapi.Charm
  • paas_app_charmer.flask.Charm
  • paas_app_charmer.go.Charm

The project structure has been changed from flat layout to src layout as it there are now two top-level packages.

As this is a new project, the version will start with 1.0.0.

Juju Events Changes

Module Changes

Library Changes

Checklist

amandahla
amandahla previously approved these changes Oct 14, 2024
pyproject.toml Show resolved Hide resolved
src/paas_app_charmer/fastapi/charm.py Show resolved Hide resolved
src/paas_app_charmer/__init__.py Show resolved Hide resolved
tests/unit/test_deprecated.py Outdated Show resolved Hide resolved
Copy link
Contributor

Test coverage for 407e7e8

Name                                          Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------------------------------------
src/paas_app_charmer/__init__.py                  2      0      0      0   100%
src/paas_app_charmer/django/__init__.py           2      0      0      0   100%
src/paas_app_charmer/django/charm.py              2      0      0      0   100%
src/paas_app_charmer/fastapi/__init__.py          2      0      0      0   100%
src/paas_app_charmer/fastapi/charm.py             2      0      0      0   100%
src/paas_app_charmer/flask/__init__.py            2      0      0      0   100%
src/paas_app_charmer/flask/charm.py               2      0      0      0   100%
src/paas_app_charmer/go/__init__.py               2      0      0      0   100%
src/paas_app_charmer/go/charm.py                  2      0      0      0   100%
src/paas_charm/__init__.py                       32     17      0      0    47%   13-14, 19-20, 26-27, 33-37, 43-44, 50-51, 57-58
src/paas_charm/_gunicorn/__init__.py              0      0      0      0   100%
src/paas_charm/_gunicorn/charm.py                15      0      0      0   100%
src/paas_charm/_gunicorn/webserver.py            83      4     14      1    95%   175, 187-193
src/paas_charm/_gunicorn/workload_config.py       8      0      0      0   100%
src/paas_charm/_gunicorn/wsgi_app.py             16      0      0      0   100%
src/paas_charm/app.py                           157      0     54      3    99%   110->exit, 167->173, 341->343
src/paas_charm/charm.py                         242     26     54      3    90%   34-35, 42-43, 205, 215-216, 218-219, 248-252, 316-318, 379-380, 385, 390, 395, 405, 410, 415, 420, 425, 450
src/paas_charm/charm_state.py                   107      2     12      2    97%   187, 277
src/paas_charm/charm_utils.py                    23      0      0      0   100%
src/paas_charm/database_migration.py             35      0      2      0   100%
src/paas_charm/databases.py                      25      2      6      1    90%   89-90
src/paas_charm/django/__init__.py                 2      0      0      0   100%
src/paas_charm/django/charm.py                   44      4      8      2    88%   48, 108, 123-124
src/paas_charm/exceptions.py                      5      0      0      0   100%
src/paas_charm/fastapi/__init__.py                2      0      0      0   100%
src/paas_charm/fastapi/charm.py                  31      0      0      0   100%
src/paas_charm/flask/__init__.py                  2      0      0      0   100%
src/paas_charm/flask/charm.py                    26      0      0      0   100%
src/paas_charm/framework.py                      23      4     12      2    77%   34, 47-49
src/paas_charm/go/__init__.py                     2      0      0      0   100%
src/paas_charm/go/charm.py                       28      0      0      0   100%
src/paas_charm/observability.py                  24      3      4      1    86%   42->46, 73-77
src/paas_charm/rabbitmq.py                       78      2     22      5    93%   117->exit, 122->exit, 157->exit, 159-160, 181->175
src/paas_charm/secret_storage.py                 50      2     14      4    91%   55->54, 56->58, 86, 105
src/paas_charm/utils.py                          44      7     14      5    79%   34, 36, 56-57, 75, 79, 104
-----------------------------------------------------------------------------------------
TOTAL                                          1122     73    216     29    92%

Static code analysis report

Run started:2024-10-15 06:14:18.148071

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2368
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 2

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@javierdelapuente javierdelapuente merged commit 862d84e into main Oct 15, 2024
97 of 101 checks passed
@javierdelapuente javierdelapuente deleted the the-renaming branch October 15, 2024 14:40
@javierdelapuente javierdelapuente restored the the-renaming branch October 17, 2024 11:31
@javierdelapuente javierdelapuente deleted the the-renaming branch October 17, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants