Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(): Enable async workers for flask and django #11

Merged
merged 30 commits into from
Dec 19, 2024
Merged
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
c9d0849
Feat(): Enable async workers for flask and django
alithethird Nov 7, 2024
f1a0151
Chore(): Log error when worker_class setting is wrong.
alithethird Nov 8, 2024
4bf80ba
chore(Lint): Run linter
alithethird Nov 8, 2024
7944182
chore(): Formatted strings
alithethird Nov 8, 2024
e173772
fix(websockets): Pinned websockets version to <14.0
alithethird Nov 12, 2024
9d7ed46
Chore(): Minor refactors. Apply comments
alithethird Nov 13, 2024
efb2b60
Chore(async): Use Enum
alithethird Nov 15, 2024
1b1ab51
Chore(Integration test): Write integration tests for async workers.
alithethird Nov 15, 2024
19f367a
Chore(): Make linter happy
alithethird Nov 15, 2024
bd15e34
Chore(): Renamed new tests.
alithethird Nov 18, 2024
5795a9b
Chore(tests): Add async config tests for Django framework
alithethird Nov 18, 2024
f2e2269
Chore(lint): Format the code
alithethird Nov 18, 2024
4435b06
Chore(docs): Update async doc link
alithethird Nov 20, 2024
231ecc7
Merge branch 'main' into async-workers
alithethird Nov 27, 2024
10a314b
Chore(): Change config tests to uni, add integration test. Other comm…
alithethird Nov 27, 2024
80146a0
Merge branch 'async-workers' of github.com:canonical/paas-charm into …
alithethird Nov 27, 2024
37333e2
Chore(lint): Format code
alithethird Nov 27, 2024
b132e1a
Chore(): Add Django test, simplify Django async test app
alithethird Nov 27, 2024
128461a
Chore(test): Improve tests and gevent module check
alithethird Nov 29, 2024
0af7325
Chore(): Changed implementation
alithethird Dec 6, 2024
637542d
Update examples/flask/flask-async.rst
alithethird Dec 6, 2024
0b255a1
Chore(): Remove wrongly placed doc
alithethird Dec 6, 2024
6d16c78
chore(test): Use branch to source compile rockcraft & charmcraft for …
alithethird Dec 12, 2024
3bdc6aa
chore(test): Fix repo links
alithethird Dec 12, 2024
88d898f
chore(test): Increase timeout in integration tests
alithethird Dec 13, 2024
703aa75
chore(): Fix compatibility issue
alithethird Dec 16, 2024
06beaf0
chore(test): Fix unit tests.
alithethird Dec 18, 2024
bb29311
chore(test): Use the latest/edge rockcraft instead of fork
alithethird Dec 19, 2024
2aac183
chore(trivy): Add 2 ignore lines for go libraries
alithethird Dec 19, 2024
c0a458a
Merge remote-tracking branch 'origin/main' into async-workers
alithethird Dec 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions examples/django/charm/charmcraft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ config:
type: string
django-secret-key-id:
description: >-
This configuration is similar to `django-secret-key`, but instead accepts a Juju user secret ID.
The secret should contain a single key, "value", which maps to the actual Django secret key.
To create the secret, run the following command:
This configuration is similar to `django-secret-key`, but instead accepts a Juju user secret ID.
The secret should contain a single key, "value", which maps to the actual Django secret key.
To create the secret, run the following command:
`juju add-secret my-django-secret-key value=<secret-string> && juju grant-secret my-django-secret-key django-k8s`,
and use the outputted secret ID to configure this option.
type: secret
Expand All @@ -69,6 +69,9 @@ config:
webserver-workers:
description: The number of webserver worker processes for handling requests.
type: int
webserver-worker-class:
description: The method of webserver worker processes for handling requests. Can be either 'gevent' or 'sync'.
type: string
containers:
django-app:
resource: django-app-image
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Copyright 2024 Canonical Ltd.
# See LICENSE file for licensing details.
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Copyright 2024 Canonical Ltd.
# See LICENSE file for licensing details.

"""
ASGI config for django_async_app project.

It exposes the ASGI callable as a module-level variable named ``application``.

For more information on this file, see
https://docs.djangoproject.com/en/5.0/howto/deployment/asgi/
"""

import os

from django.core.asgi import get_asgi_application

os.environ.setdefault("DJANGO_SETTINGS_MODULE", "django_async_app.settings")

application = get_asgi_application()
Original file line number Diff line number Diff line change
@@ -0,0 +1,130 @@
# Copyright 2024 Canonical Ltd.
# See LICENSE file for licensing details.

"""
Django settings for django_async_app project.

Generated by 'django-admin startproject' using Django 5.0.2.

For more information on this file, see
https://docs.djangoproject.com/en/5.0/topics/settings/

For the full list of settings and their values, see
https://docs.djangoproject.com/en/5.0/ref/settings/
"""

import json
import os
import urllib.parse
from pathlib import Path

# Build paths inside the project like this: BASE_DIR / 'subdir'.
BASE_DIR = Path(__file__).resolve().parent.parent


# Quick-start development settings - unsuitable for production
# See https://docs.djangoproject.com/en/5.0/howto/deployment/checklist/

# SECURITY WARNING: keep the secret key used in production secret!
SECRET_KEY = os.environ.get("DJANGO_SECRET_KEY", "secret")

# SECURITY WARNING: don't run with debug turned on in production!
DEBUG = os.environ.get("DJANGO_DEBUG", "true") == "true"

ALLOWED_HOSTS = json.loads(os.environ["DJANGO_ALLOWED_HOSTS"])


INSTALLED_APPS = [
"django.contrib.admin",
"django.contrib.auth",
"django.contrib.contenttypes",
"django.contrib.sessions",
"django.contrib.messages",
"django.contrib.staticfiles",
]

MIDDLEWARE = [
"django.middleware.security.SecurityMiddleware",
"django.contrib.sessions.middleware.SessionMiddleware",
"django.middleware.common.CommonMiddleware",
"django.middleware.csrf.CsrfViewMiddleware",
"django.contrib.auth.middleware.AuthenticationMiddleware",
"django.contrib.messages.middleware.MessageMiddleware",
"django.middleware.clickjacking.XFrameOptionsMiddleware",
]

ROOT_URLCONF = "django_async_app.urls"

TEMPLATES = [
{
"BACKEND": "django.template.backends.django.DjangoTemplates",
"DIRS": [],
"APP_DIRS": True,
"OPTIONS": {
"context_processors": [
"django.template.context_processors.debug",
"django.template.context_processors.request",
"django.contrib.auth.context_processors.auth",
"django.contrib.messages.context_processors.messages",
],
},
},
]

WSGI_APPLICATION = "django_async_app.wsgi.application"


# Database
# https://docs.djangoproject.com/en/5.0/ref/settings/#databases
DATABASES = {
"default": {
"ENGINE": "django.db.backends.postgresql",
"NAME": os.environ.get("POSTGRESQL_DB_NAME"),
"USER": os.environ.get("POSTGRESQL_DB_USERNAME"),
"PASSWORD": os.environ.get("POSTGRESQL_DB_PASSWORD"),
"HOST": os.environ.get("POSTGRESQL_DB_HOSTNAME"),
"PORT": os.environ.get("POSTGRESQL_DB_PORT", "5432"),
}
}


# Password validation
# https://docs.djangoproject.com/en/5.0/ref/settings/#auth-password-validators

AUTH_PASSWORD_VALIDATORS = [
{
"NAME": "django.contrib.auth.password_validation.UserAttributeSimilarityValidator",
},
{
"NAME": "django.contrib.auth.password_validation.MinimumLengthValidator",
},
{
"NAME": "django.contrib.auth.password_validation.CommonPasswordValidator",
},
{
"NAME": "django.contrib.auth.password_validation.NumericPasswordValidator",
},
]


# Internationalization
# https://docs.djangoproject.com/en/5.0/topics/i18n/

LANGUAGE_CODE = "en-us"

TIME_ZONE = "UTC"

USE_I18N = True

USE_TZ = True


# Static files (CSS, JavaScript, Images)
# https://docs.djangoproject.com/en/5.0/howto/static-files/

STATIC_URL = "static/"

# Default primary key field type
# https://docs.djangoproject.com/en/5.0/ref/settings/#default-auto-field

DEFAULT_AUTO_FIELD = "django.db.models.BigAutoField"
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# Copyright 2024 Canonical Ltd.
# See LICENSE file for licensing details.

"""
URL configuration for django_async_app project.

The `urlpatterns` list routes URLs to views. For more information please see:
https://docs.djangoproject.com/en/5.0/topics/http/urls/
Examples:
Function views
1. Add an import: from my_app import views
2. Add a URL to urlpatterns: path('', views.home, name='home')
Class-based views
1. Add an import: from other_app.views import Home
2. Add a URL to urlpatterns: path('', Home.as_view(), name='home')
Including another URLconf
1. Import the include() function: from django.urls import include, path
2. Add a URL to urlpatterns: path('blog/', include('blog.urls'))
"""

from django.contrib import admin
from django.urls import path
from testing.views import sleep

urlpatterns = [
path("admin/", admin.site.urls),
path("sleep", sleep, name="sleep"),
]
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Copyright 2024 Canonical Ltd.
# See LICENSE file for licensing details.

"""
WSGI config for django_async_app project.

It exposes the WSGI callable as a module-level variable named ``application``.

For more information on this file, see
https://docs.djangoproject.com/en/5.0/howto/deployment/wsgi/
"""

import os

from django.core.wsgi import get_wsgi_application

os.environ.setdefault("DJANGO_SETTINGS_MODULE", "django_async_app.settings")

application = get_wsgi_application()
26 changes: 26 additions & 0 deletions examples/django/django_async_app/django_async_app/manage.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
#!/usr/bin/env python3

# Copyright 2024 Canonical Ltd.
# See LICENSE file for licensing details.

"""Django's command-line utility for administrative tasks."""
import os
import sys


def main():
"""Run administrative tasks."""
os.environ.setdefault("DJANGO_SETTINGS_MODULE", "django_async_app.settings")
try:
from django.core.management import execute_from_command_line
except ImportError as exc:
raise ImportError(
"Couldn't import Django. Are you sure it's installed and "
"available on your PYTHONPATH environment variable? Did you "
"forget to activate a virtual environment?"
) from exc
execute_from_command_line(sys.argv)


if __name__ == "__main__":
main()
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Copyright 2024 Canonical Ltd.
# See LICENSE file for licensing details.
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Copyright 2024 Canonical Ltd.
# See LICENSE file for licensing details.

from django.contrib import admin

# Register your models here.
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Copyright 2024 Canonical Ltd.
# See LICENSE file for licensing details.

from django.apps import AppConfig


class TestingConfig(AppConfig):
default_auto_field = "django.db.models.BigAutoField"
name = "testing"
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Copyright 2024 Canonical Ltd.
# See LICENSE file for licensing details.
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Copyright 2024 Canonical Ltd.
# See LICENSE file for licensing details.

from django.db import models

# Create your models here.
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Copyright 2024 Canonical Ltd.
# See LICENSE file for licensing details.

from django.test import TestCase

# Create your tests here.
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Copyright 2024 Canonical Ltd.
# See LICENSE file for licensing details.

import time

from django.http import HttpResponse


def sleep(request):
duration = request.GET.get("duration")
time.sleep(int(duration))
return HttpResponse()
4 changes: 4 additions & 0 deletions examples/django/django_async_app/requirements.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Django
tzdata
psycopg2-binary
gevent
14 changes: 14 additions & 0 deletions examples/django/django_async_app/rockcraft.yaml
alithethird marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Copyright 2024 Canonical Ltd.
# See LICENSE file for licensing details.

name: django-async-app
summary: Example Async Django application image.
description: Example Async Django application image.
version: "0.1"
base: [email protected]
license: Apache-2.0
platforms:
amd64:

extensions:
- django-framework
9 changes: 6 additions & 3 deletions examples/flask/charmcraft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ config:
type: string
flask-secret-key-id:
description: >-
This configuration is similar to `flask-secret-key`, but instead accepts a Juju user secret ID.
The secret should contain a single key, "value", which maps to the actual Flask secret key.
To create the secret, run the following command:
This configuration is similar to `flask-secret-key`, but instead accepts a Juju user secret ID.
The secret should contain a single key, "value", which maps to the actual Flask secret key.
To create the secret, run the following command:
`juju add-secret my-flask-secret-key value=<secret-string> && juju grant-secret my-flask-secret-key flask-k8s`,
and use the outputted secret ID to configure this option.
type: secret
Expand All @@ -82,6 +82,9 @@ config:
webserver-workers:
description: The number of webserver worker processes for handling requests.
type: int
webserver-worker-class:
description: The method of webserver worker processes for handling requests. Can be either 'gevent' or 'sync'.
type: string
secret-test:
description: A test configuration option for testing user provided Juju secrets.
type: secret
Expand Down
Loading
Loading