Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifests to v1.9.0 #372

Merged
merged 8 commits into from
Jun 7, 2024
Merged

Update manifests to v1.9.0 #372

merged 8 commits into from
Jun 7, 2024

Conversation

misohu
Copy link
Member

@misohu misohu commented Jun 4, 2024

Closes: #368, #369

Contorller
I have compared tags v1.8.0 and v1.9.0-rc.1 for https://github.com/kubeflow/kubeflow/tree/master/components/notebook-controller/config/overlays/kubeflow

Web-app
I have compared tags v1.8.0 and v1.9.0-rc.1 for https://github.com/kubeflow/kubeflow/tree/master/components/crud-web-apps/jupyter

Key changes:

  • added culling env variables for notebook controller

@misohu misohu requested a review from a team as a code owner June 4, 2024 09:09
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and thorough update @misohu, good job! I left 2 small comments. The only thing that I 'd update is add a note on manifests side, this corresponds rc.1 and not rc.0, even though it corresponds to kf rc.0.

charms/jupyter-controller/tests/unit/test_operator.py Outdated Show resolved Hide resolved
charms/jupyter-controller/config.yaml Show resolved Hide resolved
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @misohu

@misohu misohu merged commit 1cde35b into main Jun 7, 2024
14 checks passed
@misohu misohu deleted the KF-5671-update-manifests-1-9-0 branch June 7, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update jupyter-controller manifests
2 participants