Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use latest JWA image #358

Merged
merged 2 commits into from
Apr 22, 2024
Merged

chore: use latest JWA image #358

merged 2 commits into from
Apr 22, 2024

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Apr 19, 2024

canonical/kubeflow-rocks#81 introduced changes in the rockcraft project that improved readability and set a standard. This commit uses the version of the container image that corresponds to that PR.

Testing instructions

With the CKF bundle:

  1. Deploy the CKF 1.8 bundle
  2. Build the charm in this PR and refresh jupyter-ui with it
  3. Login in the dashboard and confirm the Notebooks page is working correctly by creating a Notebook and interacting with the web app.

With relevant charms:

  1. Deploy istio-operators from 1.17/stable
  2. Deploy the charm in this PR
  3. Relate it to istio-pilot
  4. Wait for the charm to become active and idle
  5. Look into the container logs for any anomalies.

canonical/kubeflow-rocks#81 introduced changes in the rockcraft project that improved readability and set a standard.
This commit uses the version of the container image that corresponds to that PR.
@DnPlas DnPlas requested a review from a team as a code owner April 19, 2024 10:32
@DnPlas DnPlas enabled auto-merge (squash) April 22, 2024 10:26
@kimwnasptd
Copy link
Contributor

Tried to run the image locally and can confirm the app starts, and fails because it can't find K8s config.

@DnPlas DnPlas merged commit ab4ae7b into track/1.8 Apr 22, 2024
14 checks passed
@DnPlas DnPlas deleted the dnplas-use-ckf-jwa-image branch April 22, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants