Fix the --set-as-default-runtime deprecation warning #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoaggelos
approved these changes
Mar 23, 2024
|
@neoaggelos This should fix #272 as well since the default value for |
|
Thank you @Damowerko, could you also make sure to create a Launchpad account and sign the CLA? Then we can merge this PR. |
|
You don't need a Launchpad account to sign CLA |
louiseschmidtgen
pushed a commit
that referenced
this pull request
Apr 26, 2024
Co-authored-by: Damian Owerko <[email protected]>
louiseschmidtgen
added a commit
that referenced
this pull request
Apr 26, 2024
Co-authored-by: Damian Owerko <[email protected]> Co-authored-by: Damian Owerko <[email protected]>
|
I hope the CLA wasn't a problem. I signed it but for some reason the tests weren't passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #269.
I believe the previously intended behavior was to check if the two flags are different, but the default value of
--set-as-default-runtimewasNone, so the if statement on line 210 evaluated to True by default. Changed it the warning is written whenever the old flag is set to any value, regardless of the new flag.Thank you for making MicroK8s better
Please reference the issue this PR is fixing, or provide a description of the problem addressed.
Also verify you have: