Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update pull_request_template.md #5187

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 17 additions & 29 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,43 +1,31 @@
## Done
-

<!--
- Itemised list of what was changed by this PR.
-->

## QA
## QA steps

### MAAS deployment
- [ ]

To run this branch you will need access to one of the following MAAS deployments:

- [Karura](/HACKING.md#karura)
- [Bolla](/HACKING.md#bolla)
- [A development MAAS](/HACKING.md#development-deployment)
- [A local snap MAAS](/HACKING.md#snap-deployment) (this will not usually have machines)

### Running the branch

You can run this branch by:

- Serving with [dotrun](/HACKING.md#maas-ui-development-setup)
- [Building in a development MAAS](/HACKING.md#running-maas-ui-from-a-development-maas)

### QA steps

- Steps for QA.
<!-- Steps for QA. -->

## Fixes

Fixes: # .

## Launchpad issue

Related Launchpad maas issue in the form `lp#number`.
Fixes:

## Backports
<!-- If there's an existing JIRA/launchpad issue/bug for your change, please link to it above. -->

In general, please propose fixes against _main_ rather than release branches (e.g. 2.7), unless the fix is only applicable for that specific release. Please apply backport labels to the PR (e.g. "Backport 2.7") for the appropriate releases to target.
## Screenshots

Only bug and security fixes should be backported, new features should only land in main.
<!--
Attach any screenshots or videos that help illustrate or demonstrate the changes made in this PR.
-->

## Screenshots
## Notes

It could be helpful to provide some screenshots to aid in QAing the change.
<!--
(Optional)
Leave any additional notes for the reviewer here.
-->